Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place caret in parameter list when generating constructors. #21076

Merged

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #21008

@CyrusNajmabadi
Copy link
Member Author

Tagging @dotnet/roslyn-ide

@CyrusNajmabadi
Copy link
Member Author

retest windows_release_vs-integration_prtest please

namespace Microsoft.CodeAnalysis.CodeActions
{
/// <summary>
/// Apply this annotation to an appropriate Syntax element to request that it should be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this more carefully spec whether this will navigate to the start or end of the token? Or if it's a node is something selected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I can specify that.

@CyrusNajmabadi
Copy link
Member Author

Comments added @jasonmalinowski

@dpoeschl
Copy link
Contributor

Test failures are consistent and seem related.

@dpoeschl
Copy link
Contributor

VS test failures are being investigated.

@CyrusNajmabadi CyrusNajmabadi merged commit 93f2d3c into dotnet:master Jul 27, 2017
@CyrusNajmabadi CyrusNajmabadi deleted the genConstructorCaretPlacement branch July 27, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants