Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging VB/C# Ioperation tests #21310

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Tagging VB/C# Ioperation tests #21310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fdc1a7
Tagging VB/C# Ioperation tests
jinujoe Oct 21, 2015
5c78938
Fix the Wrong Tagging
Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Compilers/CSharp/Test/Semantic/IOperation/IOperationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace Microsoft.CodeAnalysis.CSharp.UnitTests
{
public partial class IOperationTests : SemanticModelTestBase
{
[CompilerTrait(CompilerFeature.IOperation)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tuple tests, I opted to put the trait on the class rather than individual tests, where possible. I'd suggest the same here, since the whole file is dedicated to IOperations tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true for most of the files here, tomorrow if you add more tests for other scenario will we go remember to split it ?

Copy link
Contributor

@heejaechang heejaechang Aug 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen trait on class. I think majority of roslyn tests' traits are on each test methods.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. Doesn't seem like like this file would contain tests other than IOperation...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer traits per unit tests

[Fact]
[WorkItem(382240, "https://devdiv.visualstudio.com/DevDiv/_workitems?id=382240")]
public void NullInPlaceOfParamArray()
Expand Down Expand Up @@ -69,6 +70,7 @@ static void Test2(int y, params int[] x)
OutConversion: null");
}

[CompilerTrait(CompilerFeature.IOperation)]
[Fact]
public void DeconstructionAssignmentFromTuple()
{
Expand Down Expand Up @@ -112,6 +114,7 @@ public void Deconstruct(out int a, out int b, out int c)
Assert.False(operation3 is ISimpleAssignmentExpression);
}

[CompilerTrait(CompilerFeature.IOperation)]
[Fact]
public void TestClone()
{
Expand All @@ -124,6 +127,7 @@ public void TestClone()
VerifyClone(model);
}

[CompilerTrait(CompilerFeature.IOperation)]
[Fact]
public void TestParentOperations()
{
Expand Down
74 changes: 59 additions & 15 deletions src/Compilers/CSharp/Test/Semantic/IOperation/IOperationTests_IArgument.cs
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions src/Compilers/CSharp/Test/Semantic/IOperation/IOperationTests_IBinaryOperatorExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.Test.Utilities;
using Roslyn.Test.Utilities;
using Xunit;

namespace Microsoft.CodeAnalysis.CSharp.UnitTests
{
public partial class IOperationTests : SemanticModelTestBase
{
[CompilerTrait(CompilerFeature.Determinism)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why determinism? Copy & paste error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , thatz a copy paste error ..will fix

[Fact]
public void VerifyLiftedBinaryOperators1()
{
Expand All @@ -28,6 +30,7 @@ void F(int? x, int? y)
VerifyOperationTreeForTest<BinaryExpressionSyntax>(source, expectedOperationTree);
}

[CompilerTrait(CompilerFeature.Determinism)]
[Fact]
public void VerifyNonLiftedBinaryOperators1()
{
Expand All @@ -48,6 +51,7 @@ void F(int x, int y)
VerifyOperationTreeForTest<BinaryExpressionSyntax>(source, expectedOperationTree);
}

[CompilerTrait(CompilerFeature.Determinism)]
[Fact]
public void VerifyLiftedUserDefinedBinaryOperators1()
{
Expand All @@ -69,6 +73,7 @@ void F(C? x, C? y)
VerifyOperationTreeForTest<BinaryExpressionSyntax>(source, expectedOperationTree);
}

[CompilerTrait(CompilerFeature.Determinism)]
[Fact]
public void VerifyNonLiftedUserDefinedBinaryOperators1()
{
Expand Down
Loading