Do not insert Microsoft.DiaSymReader.Native #21420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures: #21421 |
|
test windows_determinism_prtest please |
|
test windows_release_unit64_prtest please |
|
test failure: #21423 |
|
test windows_release_unit64_prtest please |
|
@dotnet/roslyn-infrastructure |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 14, 2017
…throw-statement-expression * dotnet/features/ioperation: (41 commits) Update CSharpReplaceMethodWithPropertyService.cs Add VB side of fix. Remove unneeded function. Improve trivia preservation when converting methods into a property. VB side of do-not-simplify-nameof if it changes semantics. Do not simplify to an alias in a nameof if it changes the value of hte nameof. Include System.Runtime.Serialization.Primitives and System.Security.Cryptography.Csp in PortableFacades CoreXT package. (dotnet#21438) Address one more refactoring feedback Address PR feedback Fix possible race conditions in TestExtensionErrorHandler Fix expected test results to properly consider trivia Improve messages when tests fail due to expected text Default to considering trivia during testing Remove RemoveUnneededReferences from LamdaRewriter (dotnet#21367) Enable embedding sources to Windows PDBs (dotnet#21391) re-enabled assert we have disabled Do not insert Microsoft.DiaSymReader.Native (dotnet#21420) Recommend 'case' keyword after a pattern-case-clause. Fix NamedArgumentInParameterOrderWithDefaultValue test for new IOperation output. Resolving merge conflict ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 14, 2017
…-literal-text * dotnet/features/ioperation: Update CSharpReplaceMethodWithPropertyService.cs Add VB side of fix. Remove unneeded function. Improve trivia preservation when converting methods into a property. VB side of do-not-simplify-nameof if it changes semantics. Do not simplify to an alias in a nameof if it changes the value of hte nameof. Include System.Runtime.Serialization.Primitives and System.Security.Cryptography.Csp in PortableFacades CoreXT package. (dotnet#21438) Address one more refactoring feedback Address PR feedback Fix possible race conditions in TestExtensionErrorHandler Fix expected test results to properly consider trivia Improve messages when tests fail due to expected text Default to considering trivia during testing Remove RemoveUnneededReferences from LamdaRewriter (dotnet#21367) Enable embedding sources to Windows PDBs (dotnet#21391) re-enabled assert we have disabled Do not insert Microsoft.DiaSymReader.Native (dotnet#21420) Resolving merge conflict Don't pick a project arbitrarily when navigating to symbols
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 14, 2017
…tatement-refactor * dotnet/features/ioperation: Update CSharpReplaceMethodWithPropertyService.cs Add VB side of fix. Remove unneeded function. Improve trivia preservation when converting methods into a property. VB side of do-not-simplify-nameof if it changes semantics. Do not simplify to an alias in a nameof if it changes the value of hte nameof. Include System.Runtime.Serialization.Primitives and System.Security.Cryptography.Csp in PortableFacades CoreXT package. (dotnet#21438) Address one more refactoring feedback Address PR feedback Fix possible race conditions in TestExtensionErrorHandler Fix expected test results to properly consider trivia Improve messages when tests fail due to expected text Default to considering trivia during testing Remove RemoveUnneededReferences from LamdaRewriter (dotnet#21367) Enable embedding sources to Windows PDBs (dotnet#21391) re-enabled assert we have disabled Do not insert Microsoft.DiaSymReader.Native (dotnet#21420) Resolving merge conflict Don't pick a project arbitrarily when navigating to symbols
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Aug 15, 2017
…oalescingexpression-refactor * dotnet/features/ioperation: Update CSharpReplaceMethodWithPropertyService.cs Add VB side of fix. Remove unneeded function. Improve trivia preservation when converting methods into a property. VB side of do-not-simplify-nameof if it changes semantics. Do not simplify to an alias in a nameof if it changes the value of hte nameof. Include System.Runtime.Serialization.Primitives and System.Security.Cryptography.Csp in PortableFacades CoreXT package. (dotnet#21438) Address one more refactoring feedback Address PR feedback Fix possible race conditions in TestExtensionErrorHandler Fix expected test results to properly consider trivia Improve messages when tests fail due to expected text Default to considering trivia during testing Remove RemoveUnneededReferences from LamdaRewriter (dotnet#21367) Enable embedding sources to Windows PDBs (dotnet#21391) re-enabled assert we have disabled Do not insert Microsoft.DiaSymReader.Native (dotnet#21420) Resolving merge conflict Don't pick a project arbitrarily when navigating to symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.DiaSymReader.Native is inserted by VCTools redist package. We should stop inserting it into ExternalAPIs.
I'll follow up with deleting the entry from corext config file in vsuml branch, once we insert with this change.