re-enabled asserts that got disabled before #21434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/analyzer-ioperation @cston @AlekseyTs @jcouv can you take a look? |
|
retest windows_release_unit32_prtest please |
|
retest windows_release_vs-integration_prtest please |
genlu
approved these changes
Aug 11, 2017
|
LGTM |
|
@AlekseyTs @cston can you take a look? I followed @AlekseyTs 's suggestion. |
cston
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these asserts were disabled before once I added tests that calls GetOperations over every nodes in AllInOneCS and AllInOneVB test files.
since GetOperation is supposed to handle all nodes given to it, it should not cause any assert to fire. even if it returns null if it can't handle the given node.
I talked with @AlekseyTs and he suggested checking IsSemanticModelBinder on all those asserts and re-enable those.