Don't write files in CompilerPackage if not needed #21928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Sep 6, 2017
| @@ -6,6 +6,7 @@ | |||
| using System.Reflection; | |||
| using System.IO; | |||
| using EnvDTE; | |||
| using System.Collections.Generic; | |||
| // First we want to ensure any Roslyn files with our hive name that we aren't writing -- this is probably | ||
| // leftovers from older extensions | ||
| var msbuildDirectory = new DirectoryInfo(GetMSBuildPath()); | ||
| if (msbuildDirectory.Exists) |
| foreach (var fileAndContents in filesToWrite) | ||
| { | ||
| var parentDirectory = new DirectoryInfo(Path.GetDirectoryName(fileAndContents.Key)); | ||
| if (!parentDirectory.Exists) |
There was a problem hiding this comment.
The if is unnecessary here. The Create method is a no-op if the directory exists.
CompilerPackage was previously being lazy and would just delete and rewrite files as needed when the package was loaded, even if the machine would ultimately be left in the same state at the end. For the old project system (which didn't monitor such file changes) this wasn't bad, but with the new project system it now reloads projects in response to changes which can be quite expensive. Fixes dotnet#21838.
jasonmalinowski
force-pushed
the
dont-write-compilerpackage-files-if-not-needed
branch
from
ebb9e2d
to
abe47f7
Compare
jaredpar
approved these changes
Sep 6, 2017
| continue; | ||
| } | ||
|
|
||
| File.WriteAllText(fileAndContents.Key, fileAndContents.Value); |
There was a problem hiding this comment.
Nit: consider using an explicit encoding in all the file ops here. I often find this useful when doing content comparison. Reduces chances of enocding probs. Not a blocker.
|
@dotnet-bot retest this please. |
jasonmalinowski
deleted the
dont-write-compilerpackage-files-if-not-needed
branch
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompilerPackage was previously being lazy and would just delete and
rewrite files as needed when the package was loaded, even if the
machine would ultimately be left in the same state at the end.
For the old project system (which didn't monitor such file changes)
this wasn't bad, but with the new project system it now reloads projects
in response to changes which can be quite expensive.
Fixes #21838.