Fix netcoreapp2.0 use in TestUtilities #25386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Roslyn code base defaults to enabling the `<DisableImplicitFrameworkReferences>` property and instead specifies manual references. This is mostly an artifact of our code base evolution from the project.json days where implicit references weren't an option. This means that even though TestUtilities specified netcoreapp2.0 as a TF it was still mostly targeting netstandard1.3. This is because implicit references weren't expanded and we were manually adding only a subset of the available packages. Enabled implicit references here, conditioned the explicit ones to netstandard1.3 and now we can remove a number of `#if` uses. closes dotnet#25228
|
CC @roslyn-compiler for review |
jcouv
approved these changes
Mar 9, 2018
This is referenced in the TestUtilities.csproj but for some reason not explicitly copied to the output folder here. Manually adding for now. dotnet/sdk#2035
333fred
approved these changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Roslyn code base defaults to enabling the
<DisableImplicitFrameworkReferences>property and instead specifies manualreferences. This is mostly an artifact of our code base evolution from
the project.json days where implicit references weren't an option.
This means that even though TestUtilities specified netcoreapp2.0 as a
TF it was still mostly targeting netstandard1.3. This is because
implicit references weren't expanded and we were manually adding only a
subset of the available packages.
Enabled implicit references here, conditioned the explicit ones to
netstandard1.3 and now we can remove a number of
#ifuses.closes #25228
Ask Mode template not completed
Customer scenario
What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)
Bugs this fixes
(either VSO or GitHub links)
Workarounds, if any
Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
Risk
This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code
Performance impact
(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")
Is this a regression from a previous update?
Root cause analysis
How did we miss it? What tests are we adding to guard against it in the future?
How was the bug found?
(E.g. customer reported it vs. ad hoc testing)
Test documentation updated?
If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.