Removing package dependency for Microsoft.VisualStudio.Text.UI.Wpf #25546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CSharpEditorFeatures
jasonmalinowski
approved these changes
Mar 17, 2018
|
@Pilchie for ask mode approval, thanks! |
jinujoseph
approved these changes
Mar 18, 2018
|
@JieCarolHu For infrastructure / packaging changes we traditionally haven't required ask mode. So if you think this is good to merge, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing package dependency for Microsoft.VisualStudio.Text.UI.Wpf in EditorFeatures and CSharpEditorFeatures projects
Customer scenario
These non-wpf projects should not refer to the Microsoft.VisualStudio.Text.UI.Wpf package.
Bugs this fixes
#24162
Workarounds, if any
No
Risk
Low, these projects do not use the Microsoft.VisualStudio.Text.UI.Wpf package.
Performance impact
No
Is this a regression from a previous update?
No
Root cause analysis
NA
How was the bug found?
We found it when working on a bug customer reported.
Test documentation updated?
NA