[SQLite] Fix continuous probing for sqlite

src/VisualStudio/CSharp/Test/PersistentStorage/SQLitePersistentStorageTests.cs

@@ -17,6 +17,11 @@ namespace Microsoft.CodeAnalysis.UnitTests.WorkspaceServices
     /// </remarks>
     public class SQLitePersistentStorageTests : AbstractPersistentStorageTests
     {
+        static SQLitePersistentStorageTests()
+        {
+            Assert.True(SQLitePersistentStorageService.TryInitializeLibraries());
+        }
+
         internal override IPersistentStorageService GetStorageService(IPersistentStorageLocationService locationService, ISolutionSizeTracker solutionSizeTracker, IPersistentStorageFaultInjector faultInjector)
             => new SQLitePersistentStorageService(_persistentEnabledOptionService, locationService, solutionSizeTracker, faultInjector);
 

src/Workspaces/Core/Desktop/Workspace/SQLite/SQLitePersistentStorage.cs

@@ -3,7 +3,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Runtime.InteropServices;
 using System.Threading;
 using Microsoft.CodeAnalysis.Host;
 using Microsoft.CodeAnalysis.Options;
@@ -93,33 +92,6 @@ internal partial class SQLitePersistentStorage : AbstractPersistentStorage
         private const string DataIdColumnName = "DataId";
         private const string DataColumnName = "Data";
 
-        static SQLitePersistentStorage()
-        {
-            // Attempt to load the correct version of e_sqlite.dll.  That way when we call
-            // into SQLitePCL.Batteries_V2.Init it will be able to find it.
-            //
-            // Only do this on Windows when we can safely do the LoadLibrary call to this
-            // direct dll.  On other platforms, it is the responsibility of the host to ensure
-            // that the necessary sqlite library has already been loaded such that SQLitePCL.Batteries_V2
-            // will be able to call into it.
-            if (Environment.OSVersion.Platform == PlatformID.Win32NT)
-            {
-                var myFolder = Path.GetDirectoryName(
-                    typeof(SQLitePersistentStorage).Assembly.Location);
-
-                var is64 = IntPtr.Size == 8;
-                var subfolder = is64 ? "x64" : "x86";
-
-                LoadLibrary(Path.Combine(myFolder, subfolder, "e_sqlite3.dll"));
-            }
-
-            // Necessary to initialize SQLitePCL.
-            SQLitePCL.Batteries_V2.Init();
-        }
-
-        [DllImport("kernel32.dll")]
-        private static extern IntPtr LoadLibrary(string dllToLoad);
-
         private readonly CancellationTokenSource _shutdownTokenSource = new CancellationTokenSource();
 
         private readonly IDisposable _dbOwnershipLock;

src/Workspaces/Core/Desktop/Workspace/SQLite/SQLitePersistentStorageService.cs

@@ -2,6 +2,7 @@
 
 using System;
 using System.IO;
+using System.Runtime.InteropServices;
 using Microsoft.CodeAnalysis.Host;
 using Microsoft.CodeAnalysis.Options;
 using Microsoft.CodeAnalysis.Shared.Utilities;
@@ -19,6 +20,47 @@ internal partial class SQLitePersistentStorageService : AbstractPersistentStorag
 
         private readonly IPersistentStorageFaultInjector _faultInjectorOpt;
 
+        [DllImport("kernel32.dll")]
+        private static extern IntPtr LoadLibrary(string dllToLoad);
+
+        internal static bool TryInitializeLibraries() => s_initialized.Value;
+
+        private static readonly Lazy<bool> s_initialized = new Lazy<bool>(() => TryInitializeLibrariesLazy());
+
+        private static bool TryInitializeLibrariesLazy()
+        {
+            // Attempt to load the correct version of e_sqlite.dll.  That way when we call
+            // into SQLitePCL.Batteries_V2.Init it will be able to find it.
+            //
+            // Only do this on Windows when we can safely do the LoadLibrary call to this
+            // direct dll.  On other platforms, it is the responsibility of the host to ensure
+            // that the necessary sqlite library has already been loaded such that SQLitePCL.Batteries_V2
+            // will be able to call into it.
+            if (Environment.OSVersion.Platform == PlatformID.Win32NT)
+            {
+                var myFolder = Path.GetDirectoryName(
+                    typeof(SQLitePersistentStorage).Assembly.Location);
+
+                var is64 = IntPtr.Size == 8;
+                var subfolder = is64 ? "x64" : "x86";
+
+                LoadLibrary(Path.Combine(myFolder, subfolder, "e_sqlite3.dll"));
+            }
+
+            try
+            {
+                // Necessary to initialize SQLitePCL.
+                SQLitePCL.Batteries_V2.Init();
+            }
+            catch (Exception e) when (e is DllNotFoundException || e is EntryPointNotFoundException)
+            {
+                StorageDatabaseLogger.LogException(e);
+                return false;
+            }
+
+            return true;
+        }
+
         public SQLitePersistentStorageService(
             IOptionService optionService,
             IPersistentStorageLocationService locationService,
@@ -66,7 +108,17 @@ protected override bool TryOpenDatabase(
             }
             catch (Exception)
             {
-                sqlStorage?.Dispose();
+                if (sqlStorage != null)
+                {
+                    // Dispose of the storage, releasing the ownership lock.
+                    sqlStorage.Dispose();
+                }
+                else
+                {
+                    // The storage was not created so nothing owns the lock.
+                    // Dispose the lock to allow reuse.
+                    dbOwnershipLock.Dispose();
+                }
                 throw;
             }
 
@@ -98,10 +150,7 @@ private static void EnsureDirectory(string databaseFilePath)
             Directory.CreateDirectory(directory);
         }
 
-        protected override bool ShouldDeleteDatabase(Exception exception)
-        {
-            // Error occurred when trying to open this DB.  Try to remove it so we can create a good dB.
-            return true;
-        }
+        // Error occurred when trying to open this DB.  Try to remove it so we can create a good DB.
+        protected override bool ShouldDeleteDatabase(Exception exception) => true;
     }
 }

src/Workspaces/Core/Desktop/Workspace/Storage/PersistenceStorageServiceFactory.cs

@@ -28,6 +28,11 @@ public IWorkspaceService CreateService(HostWorkspaceServices workspaceServices)
             switch (database)
             {
                 case StorageDatabase.SQLite:
+                    if (!SQLitePersistentStorageService.TryInitializeLibraries())
+                    {
+                        break;
+                    }
+
                     var locationService = workspaceServices.GetService<IPersistentStorageLocationService>();
 
                     if (locationService != null)