Add unit test leg on ES image #25629
Conversation
This adds a unit test leg which runs on a Windows machine with only the ES language installed. This should help us catch issues that make contribution difficult for developers who don't run English as their primary language on Windows.
|
CC @dotnet/roslyn-infrastructure for review |
|
test ci please |
netci.groovy
Outdated
|
|
||
| def triggerPhraseOnly = false | ||
| def triggerPhraseExtra = "" | ||
| Utilities.setMachineAffinity(myJob, 'Windows_NT', 'Windows.10.Amd64.ClientRS3.ES.Open') |
There was a problem hiding this comment.
Should be: Utilities.setMachineAffinity(myJob, 'Windows.10.Amd64.ClientRS3.ES.Open')
netci.groovy
Outdated
| commitPullList.each { isPr -> | ||
| def jobName = Utilities.getFullJobName(projectName, "windows_debug_es_unit32", isPr) | ||
| def myJob = job(jobName) { | ||
| description("Windows CoreCLR unit tests") |
There was a problem hiding this comment.
Description here doesn't seem to match the cibuild.cmd invocation? (I presume we'd want to run all tests instead of CoreCLR tests anyways to get IDE coverage too.)
netci.groovy
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| // Windows ES image | ||
| commitPullList.each { isPr -> | ||
| def jobName = Utilities.getFullJobName(projectName, "windows_debug_es_unit32", isPr) |
There was a problem hiding this comment.
Might want to spell out "Spanish" here; es could mean any number of things if you don't already know what this is.
There was a problem hiding this comment.
ES is the actual language code to my understanding. I was trying to be most specific. Switched to Spanish.
There was a problem hiding this comment.
It's 100% precise, and 100% obtuse. 😄
|
@jasonmalinowski PR issues adressed |
|
test ci please |
|
Lets see how this goes ... |
This adds a unit test leg which runs on a Windows machine with only the
ES language installed. This should help us catch issues that make
contribution difficult for developers who don't run English as their
primary language on Windows.