Re-enable integration tests against the newer image #25653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had disabled integration tests in -vs-deps since we were regularly moving to new Visual Studio APIs and we were waiting to get new imaging systems setup. Now that things have stabilized and we have new images, we can use them.
|
@dotnet-bot test ci please. |
8 tasks
333fred
reviewed
Mar 21, 2018
netci.groovy
Outdated
| def myJob = job(jobName) { | ||
| description("Windows ${configuration} tests on ${buildTarget}") | ||
| steps { | ||
| batchFile(""".\\build\\scripts\\cibuild.cmd ${(configuration == 'debug') ? '-debug' : '-release'} -testVsi""") |
There was a problem hiding this comment.
The current pattern matches elsewhere in the file. I'm trusting that overall this is just a revert of a previous change that decided to use deletion instead of commenting.
333fred
approved these changes
Mar 21, 2018
sharwell
approved these changes
Mar 21, 2018
netci.groovy
Outdated
| def myJob = job(jobName) { | ||
| description("Windows ${configuration} tests on ${buildTarget}") | ||
| steps { | ||
| batchFile(""".\\build\\scripts\\cibuild.cmd ${(configuration == 'debug') ? '-debug' : '-release'} -testVsi""") |
There was a problem hiding this comment.
The current pattern matches elsewhere in the file. I'm trusting that overall this is just a revert of a previous change that decided to use deletion instead of commenting.
|
@dotnet-bot test ci please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had disabled integration tests in -vs-deps since we were regularly moving to new Visual Studio APIs and we were waiting to get new imaging systems setup. Now that things have stabilized and we have new images, we can use them.