Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer Microsoft.VSSDK.BuildTools #25688

Merged

Conversation

jasonmalinowski
Copy link
Member

This fixes issues where CreatePkgDef needs to get a long command line
longer than the usual Windows limit.

@jasonmalinowski jasonmalinowski requested a review from a team as a code owner March 23, 2018 20:05
@jasonmalinowski
Copy link
Member Author

Oh, this breaks some things we were depending on. This build will probably pass, but the Roslyn uber-vsix won't correctly install. Ugh.

@jasonmalinowski jasonmalinowski force-pushed the update-vs-sdk-package branch 2 times, most recently from 1a23d89 to 1a95baf Compare March 23, 2018 21:30
@jasonmalinowski jasonmalinowski changed the title Upgrade to newer MicrosoftVSSDKBuildToolsVersion Upgrade to newer Microsoft.VSSDK.BuildTools Mar 23, 2018
This fixes issues where CreatePkgDef needs to get a long command line
longer than the usual Windows limit.
@jasonmalinowski jasonmalinowski requested a review from a team as a code owner March 23, 2018 22:15
@jasonmalinowski jasonmalinowski self-assigned this Mar 23, 2018
@jasonmalinowski
Copy link
Member Author

This is blocking the integration test passes if they run on machines with the previous image setup.

@jasonmalinowski jasonmalinowski merged commit e78be20 into dotnet:dev15.7.x Mar 24, 2018
@jasonmalinowski jasonmalinowski deleted the update-vs-sdk-package branch March 24, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant