Merge 'dotnet/dev15.7.x' into DefaultInterfaceImplementation #25877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CSharpEditorFeatures
Allow indexing fixed fields in movable contexts without pinning.
…ic-jitting Add more casts to (object) to avoid JITting the dynamic binder
Fix race condition in analyzer driver where multiple threads attempti…
This moves all of our build diagnistic output into the same folder: Binaries\Configuration\Logs. Having it in a single folder is necessary for us to upload the information using the VSTS Build Artifact task. Jenkins should be unaffected. It supports and uses wildcards for the file types we need to be uploaded on failed builds.
Move all build diagnostic info into Logs dir
…the ability to capture dumps.
* Remove src/Setup/DevDivPackagesRoslyn/ This contained a list of packages that we depended on and needed facades deployed into Visual Studio. We already have VisualStudioSetup.Dependencies that already (should have...) contained all the facades and more. We can just consume that project instead of having yet another duplication of facade lists. * Fix casing * Also include the CompilerExtension as a source of facades that we must include This ensures that if the compiler adds a new facade but we don't update VisualStudioSetup.Dependencies (either intentionally or by accident) we still will include the right facades. * Include DevDivPackagesDebugger into Roslyn.sln By doing this, the VisualStudioSetup.Dependencies.csproj will now figure out the highest version of our own dependencies and the debugger dependencies, and create a single package that we can deploy that contains all of them. * Exclude inserting packages that are created by VS itself * Remove ProjectGuid from DevDivPackagesDebugger.csproj This makes BuildBoss happy.
Reduce number of stack frames to prevent StackOverflow until we have …
…apshot without changes (dotnet#25576) * Fixed DDRIT failure (dotnet#25551) * made sure we raise workspace changed events even when there is no text change. this is needed to bring workspace up to date with latest text snapshot after we don't merge 2 text snapshot to 1 source text if content is same. see this for more detail - dotnet#24849 * added comments on why we need to process all text change events * removed changes empty check. now it is possible to have empty changes. * remove non-empty from comment since set now can be empty.
Run integration tests on an STA thread
This fixes a signing regression caused be dotnet#25751. That changed us to directly call the SWIX build props / targets vs. getting them implicitly from the microbuild props / targets. One of the behaviors that the microbuild props / targets had that wasn't accounted for was the signing of the VSIX after they are constructed. Hence this lead to signing errors on insertion. This PR fixes that by making the following changes: 1. Adds SWIX VSIX to SignToolData.json so they are accounted for during normal batch signing. 1. Moves the SWIX build to the pre-sign portion of our build. 1. Removes the references from VSMAN -> SWIX. These references are there only to enforce ordering which is unnecessary. Having them remain risks that building the VSMAN will cause the SWIX to be re-built which could possibly invalidate signing.
Fix signing of swix project output
The implementations of ISuggestedAction use threading assertions instead of automatic transition to the correct thread, placing the burden of correct thread selection on the caller, TextViewWindow_InProc. This change switches to the vs-threading approach for maintaining thread affinity, which has two parts: 1. When entering thread-affinitized code, switch to the correct thread 2. Avoid using ConfigureAwait(false) to lose the required affinity The entire file relies on the default behavior of ConfigureAwait, which is the normal coding practice in asynchronous code following vs-threading patterns.
Make escape analysis over unexpected nodes to return conservative results
Further work to stabilize the integration test interop layer
The getter is 'Enabled' and the setter is 'SetEnabled_OnlyUseExportProviderAttributeCanCall'.
This change ensures that all work added to the work queue after disconnection is immediately cancelled.
While it doesn't make sense to still be requesting foreground actions after cancellation is requested, tracking down all callers of IForegroundNotificationService to ensure the proper checks are in place can be tedious. This change treats IForegroundNotificationService as the gatekeeper for scheduling asynchronous operations, and proactively cancels operations if requested before adding them to the work queue.
Isolate tests
AlekseyTs
changed the title
AlekseyTs
added
Area-Compilers
PR For Personal Review Only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.