Remove duplicate references in tests #27307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the resource DLL which corrects the version of mscorlib for the net45beta resource.
This updates our duplicate reference check to compare names in addition to reference identity. This found ~600 tests which were inadvertently passing duplicate references to our compilation helpers. closes dotnet#25509
Member
Author
|
CC @roslyn-compiler for review |
jcouv
reviewed
May 31, 2018
| "; | ||
|
|
||
| var compilation = CreateCompilation(source, references: new[] { arSA, enUS }); | ||
| var compilation = CreateEmptyCompilation(source, TargetFrameworkUtil.StandardReferences.AddRange(new[] { arSA, enUS })); |
Member
There was a problem hiding this comment.
Nit: maybe we should have an AddRange with params?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the compilation test helpers to detect when duplicate references are passed to it. For instance two versions of mscorlib, System.Core, etc ... Most of this change is fixing up the ~600 places where we incorrectly passed duplicate references. The handful of places where we deliberately passed duplicates were updated to use the correct helpers.