Updating the OptimizationData to 2.9.0-beta7-63018-03-01 #28332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
approved these changes
Jul 6, 2018
Member
|
Merging. CI was validated previously in the opt-prof validation branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer scenario
An additional assembly is loaded into memory (aka the worst thing that can ever happen)
Bugs this fixes
internal VSTS Bug
Workarounds, if any
None, the new code is part of a compatibility path required to preserve some user code style settings during the 15.8 upgrade process, so addressing the assembly code by removing the new code path has a high risk of frustrating users.
Risk
We already know about the increase in VM size and have gotten an exception
Performance impact
reduced JIT time by 17%
Is this a regression from a previous update?
Yes
Root cause analysis
Introduced with #26165. XDocument assemblies are now loaded because they are not properly NGEN'd
How was the bug found?
RPS testing