Use Microsoft.NetFramework.ReferenceAssemblies #29827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
reviewed
Sep 14, 2018
| @@ -80,7 +80,7 @@ | |||
| <MicrosoftNETCorePortableCompatibilityVersion>1.0.1</MicrosoftNETCorePortableCompatibilityVersion> | |||
| <MicrosoftNETCoreRuntimeCoreCLRVersion>2.0.0</MicrosoftNETCoreRuntimeCoreCLRVersion> | |||
| <MicrosoftNETCoreTestHostVersion>1.1.0</MicrosoftNETCoreTestHostVersion> | |||
| <MicrosoftNetFX20Version>1.0.3</MicrosoftNetFX20Version> | |||
| <MicrosoftNetFrameworkReferenceAssembliesVersion>1.0.0-alpha-004</MicrosoftNetFrameworkReferenceAssembliesVersion> | |||
There was a problem hiding this comment.
Shouldn't we also be deleting the old package we used to use?
There was a problem hiding this comment.
Deleting the code that produces that produces that package? I think I already did that before :)
There was a problem hiding this comment.
No I meant deleting the package that brings in the reference assemblies that I created some time ago. That is referenced here and it would seem this supercedes it now: RoslynToolsReferenceAssembliesVersion
There was a problem hiding this comment.
Oh, that thing. Yeah, I'll delete that.
There was a problem hiding this comment.
that thing
that glorious awful hack 😄
jaredpar
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure only.
These are some changes extracted from NetStandard 2.0 PR that can be merged without moving to NS2.0.