Use Arcade bootstrapping scripts #30498
Conversation
tmat
force-pushed
the
DotNet
branch
2 times, most recently
from
60206b5 to
462054c
Compare
tmat
changed the title
|
@jaredpar PTAL |
| @@ -35,4 +35,23 @@ | |||
| <Import Project="OptimizationData.targets"/> | |||
| <Import Project="SymStore.targets"/> | |||
|
|
|||
| <UsingTask TaskName="Microsoft.DotNet.Arcade.Sdk.LocateDotNet" AssemblyFile="$(RoslynToolsBuildTasksAssembly)" /> | |||
|
|
|||
| <Target Name="InitializeDotNetToolPath" Condition="'$(DotNetTool)' == ''"> | |||
There was a problem hiding this comment.
Does this mean that VS based builds could pick up the dotnet install that our scripts bootstrap?
There was a problem hiding this comment.
This target makes the DotNetTool variable available in the build no matter how it's triggered (build script, msbuild directly or from VS). The only place I'm aware now that needs this is running tests via msbuild /t:test. We can indeed use this target whenever we need to find dotnet.
There was a problem hiding this comment.
So is that a yes? Or do we still have to run the .NET SDK MSI before we can build Roslyn?
There was a problem hiding this comment.
The target will fail if it can't find the right version of .NET SDK. It won't try to install it.
|
Done with review pass iteration #2 |
tmat
force-pushed
the
DotNet
branch
3 times, most recently
from
6e21b9a to
c39ee87
Compare
|
@jaredpar PTAL. The change now includes msbuild and dotnet SDK version checking. |
| MSBuildMinimumDisplayVersion="MSBuild 15.7" | ||
| /> | ||
| <UsingTask TaskName="Microsoft.DotNet.Arcade.Sdk.CompareVersions" AssemblyFile="$(RoslynToolsBuildTasksAssembly)" /> | ||
| <UsingTask TaskName="Microsoft.DotNet.Arcade.Sdk.SingleError" AssemblyFile="$(RoslynToolsBuildTasksAssembly)" /> |
There was a problem hiding this comment.
Why are things in Arcade with AssemblyFile == $(RoslynToolsBuildTasksAssembly)?
There was a problem hiding this comment.
Will move these to Arcade SDK proper.
…out-if-error-message * origin/master: (1712 commits) User-defined operator checks should ignore differences in tuple member names (dotnet#30774) Attempted fix for correctly reporting error CS1069 when using implicit namespaces (dotnet#30244) Invert the binding order of InitializerExpressions and CreationExpressions (dotnet#30805) Use Arcade bootstrapping scripts (dotnet#30498) Ensure that the compilers produce double.NaN values in IEEE canonical form. (dotnet#30587) Remove properties set in BeforeCommonTargets.targets Fix publishing of dependent projects Contributing page: reference Unix build instructions Delete 0 Propagate values from AbstractProject to VisualStudioProjectCreationInfo Fix publishing nuget info of dev16.0.x-vs-deps branch Revert "Add a SetProperty API for CPS to passing msbuild properties" Validate generic arguments in `using static` directives (dotnet#30737) Correct 15.9 publish data Enable test. Do not inject attribute types into .Net modules. Add a SetProperty API for CPS to passing msbuild properties Revert "add beta2 suffix to dev16 branch" Fix references Remove commit sha from package versions ...
Use Arcade bootstrapping scripts to install dotnet cli.