Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NullableReferenceTypes msbuild property #30574

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Oct 18, 2018

Aleksey recently added a /nullable(+/-) command-line option (#30479). We also need to surface that property via Csc task and our targets file.

FYI @rainersigwald @nguerrera @davkean
We don't expect the property name "NullableReferenceTypes" would cause any conflicts.

@jcouv jcouv added this to the 16.0 milestone Oct 18, 2018
@jcouv jcouv requested a review from a team as a code owner October 18, 2018 00:29
@jcouv jcouv self-assigned this Oct 18, 2018
@jcouv jcouv merged commit f0b48aa into dotnet:features/NullableReferenceTypes Oct 18, 2018
@jcouv jcouv deleted the nullable-task branch October 18, 2018 05:42
@rainersigwald
Copy link
Member

I agree that that seems unique enough to not worry about it :shipit:

@jasonmalinowski
Copy link
Member

@jcouv @jaredpar Was this tested with the IDE to verify it's flowing through the project system?

@jasonmalinowski
Copy link
Member

(I guess asking @dpoeschl too who might have indeed done the testing)

@jcouv
Copy link
Member Author

jcouv commented Oct 19, 2018

I was only able to test at the level of Csc task. It would be good to test end-to-end but I didn't think we have a way to test the targets file change, from last discussion with Jared.
I intended to do some validation on internal preview, but nullable feature hasn't flowed throw yet when I left, let alone this change.

@jasonmalinowski
Copy link
Member

@jcouv @jaredpar The CompilerExtension should totally deploy that and work fine. Just build the entire solution locally and F5. Did we break that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants