Fix IndexOutOfRange exception in InvocationExpressionSignatureHelpProvider #30997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
reviewed
Nov 6, 2018
src/Features/CSharp/Portable/SignatureHelp/InvocationExpressionSignatureHelpProvider.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Nov 6, 2018
| ConvertMethodGroupMethod(m, invocationExpression, semanticModel, symbolDisplayService, anonymousTypeDisplayService, documentationCommentFormattingService, cancellationToken)).ToList(); | ||
| return (accessibleMethods.Select(m => | ||
| ConvertMethodGroupMethod(m, invocationExpression, semanticModel, symbolDisplayService, anonymousTypeDisplayService, documentationCommentFormattingService, cancellationToken)).ToList(), | ||
| TryGetSelectedIndex(accessibleMethods, currentSymbol)); |
There was a problem hiding this comment.
TryGetSelectedIndex(accessibleMethods, currentSymbol) [](start = 16, length = 53)
📝 if I understood the change correctly, this is the crux of the fix. We're calling TryGetSelectedIndex with accessibleMethods rather than methodGroup, so that the returned index is in bound of the relevant range (ie. that of accessibleMethods).
jcouv
approved these changes
Nov 6, 2018
|
lets keep for preview2 , holding this till the branch is ready |
|
@jinujoseph Seems P2 branch is open for business. Do I need anyone's approval to merge? |
|
Approved to merge for 16.0.P2 once green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @dpoeschl @jcouv
I just found this issue while dogfooding, haven't filed a bug for it yet.
@jinujoseph Do we want this for P1?