Exhaustiveness checking tracks only non-null decision paths #31093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses part of dotnet#30597 Later, in a separate PR, the null paths will be checked in the nullable walker
cston
reviewed
Nov 12, 2018
| else | ||
|
|
||
| // We only report exhaustive warnings when the default label is reachable through some series of | ||
| // tests that do not include a test in which the value is know to be null. Handling paths with |
There was a problem hiding this comment.
know [](start = 70, length = 4)
known?
cston
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #30597
Later, in a separate PR, the null paths will be checked in the nullable walker