Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RepoRoot instead of repoDir #31155

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Nov 13, 2018

This variable was renamed in a different branch than where the optprof changes where originally merged. Once the dev16p1 changes where merged to master the rename from here #30498 collided badly and broke the build

@jmarolf jmarolf requested a review from a team as a code owner November 13, 2018 23:20
@jmarolf
Copy link
Contributor Author

jmarolf commented Nov 13, 2018

Signed build for verification here

@jinujoseph jinujoseph added this to the 16.0.P2 milestone Nov 14, 2018
@jmarolf
Copy link
Contributor Author

jmarolf commented Nov 14, 2018

@jasonmalinowski signed build is green so I am going to merge

@jmarolf jmarolf merged commit 23b2690 into dev16.0-preview2-vs-deps Nov 14, 2018
@sharwell sharwell deleted the infrastructure/fix-build branch November 14, 2018 22:59
xoofx pushed a commit to stark-lang/stark-roslyn that referenced this pull request Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants