Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy nullability of struct fields of unconstrained type #32402

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Copy nullability of struct fields of unconstrained type #32402

merged 1 commit into from
Jan 12, 2019

Conversation

cston
Copy link
Member

@cston cston commented Jan 11, 2019 •
edited
Loading

Fixes #32338.

@cston
Copy link
Member Author

cston commented Jan 11, 2019

@dotnet/roslyn-compiler please review.

@jcouv jcouv added this to the 16.0.P3 milestone Jan 11, 2019
jcouv
jcouv approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jan 11, 2019
@cston
Copy link
Member Author

cston commented Jan 12, 2019

@dotnet/roslyn-compiler for a second review of this small change, thanks.

AlekseyTs
AlekseyTs reviewed Jan 12, 2019
View reviewed changes
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
}
}";
var comp = CreateCompilation(source, options: WithNonNullTypesTrue());
// https://github.com/dotnet/roslyn/issues/29970: Should not report warning for `z.Item1`.
Copy link
Contributor

@AlekseyTs AlekseyTs Jan 12, 2019 •
edited by cston
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#29970 [](start = 15, length = 45)

Consider adding this as another WorkItem #Pending

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add in next PR.

In reply to: 247292493 [](ancestors = 247292493)

AlekseyTs
AlekseyTs approved these changes Jan 12, 2019
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@cston cston merged commit e05f228 into dotnet:master Jan 12, 2019
@cston cston deleted the 32338 branch January 12, 2019 05:32
xoofx pushed a commit to stark-lang/stark-roslyn that referenced this pull request Apr 16, 2019
@cston
Copy nullability of struct fields of unconstrained type (dotnet#32402)
e3d00d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.0.P3
Development

Successfully merging this pull request may close these issues.
3 participants
@cston @AlekseyTs @jcouv