Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into features/readonly-members #33326

Merged
merged 563 commits into from
Feb 13, 2019
Merged

Conversation

RikkiGibson
Copy link
Contributor

Bringing this feature branch up to date.

JoeRobich and others added 30 commits January 31, 2019 14:13
This is a reworked version of #32395 targeting the dev16.0-preview3 branch.
Avoid unnecessary thread-local variables
Prior implementation looked for specific unhandled operation tree shapes and was agressive, leading to false positives. New implementation handles only specific operation tree shapes and is much more conservative.

Fixes #32946
Fixes #32924
Add feature to make applicable local functions static.
sharwell and others added 13 commits February 11, 2019 13:08
Parallel.For operations wrap exceptions in an AggregateException, which
destroys dump information. This change should crash the process on a parse
exception and preserve the dump information for Watson.
…used parameters and values analyzer.

Unfortunately, this operation is not an ICompoundAssignmentOperation, hence needs to be handled specially by analyzers that need to analyze read/writes.
Also added support to the fixer to handle coalesce assignments.

Fixes #33299
Revert "Add an adapter assembly for MonoDevelop"
Fixes AddUsingExactMatchBeforeRenameTracking integration test
jaredpar and others added 6 commits February 12, 2019 13:20
Nullable constraint checking outside method bodies
The assert for custom modifier checking should include the nullable
validation

closes #30740
Reduce allocations in the formatter
* Reference Microsoft.NetFramework.Analyzers and fix violations
Correct assert in CustomModifierUtils
dibarbet and others added 4 commits February 12, 2019 16:44
Fix unnecessary cast warning in conditional expressions when required.  Resolves #26640
Handle the newly added null coalescing assignment operation in the un…
@RikkiGibson RikkiGibson merged commit 6b36c24 into features/readonly-members Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.