Delete unnecessary code around Workspace eventing #33368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some code in the VS layer that was trying to work around the fact that we might be MEF created on a background thread, when were didn't know what the UI thread was. It tried to assert that the first actual workspace mutation would happen on the UI thread, and so it was safe to create the queue at that point. This is silly now for two reasons: 1. We're using the IThreadingContext which knows what the main thread is directly and without any ceremony 2. We now do indeed do workspace mutations on other threads. It's still the case that the first mutation is on the UI thread today but that's a limitation we are actively wanting to excise.
jasonmalinowski
deleted the
delete-unnecessary-code-around-workspace-eventing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some code in the VS layer that was trying to work around the fact that we might be MEF created on a background thread, when were didn't know what the UI thread was. It tried to assert that the first actual workspace mutation would happen on the UI thread, and so it was safe to create the queue at that point. This is silly now for two reasons: