Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PublishData.json #33396

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Update PublishData.json #33396

merged 2 commits into from
Feb 15, 2019

Conversation

RikkiGibson
Copy link
Contributor

Change lab/ml to master now that we're inserting our 16.1 payloads into VS master

Change lab/ml to master now that we're inserting our 16.1 payloads into VS master
This is needed for building VS bootstrapper for IBC training.
@tmat
Copy link
Member

tmat commented Feb 14, 2019

Thanks! I also added vsMajorVersion field, which we will need soon.

@tmat
Copy link
Member

tmat commented Feb 14, 2019

@jaredpar

@RikkiGibson RikkiGibson requested a review from tmat February 14, 2019 22:55
@tmat
Copy link
Member

tmat commented Feb 14, 2019

@jaredpar Are the feature branches up to date? they list some old versions (2.8., 2.11.)

@jaredpar
Copy link
Member

@tmat

Are the feature branches up to date? they list some old versions (2.8., 2.11.)

That's because i never added the proper validation code for that field. This file is out of date for feature branches though. I will try and get that cleaned up here.

@tmat
Copy link
Member

tmat commented Feb 15, 2019

Let's merge this now so we can unblock #33410

@tmat tmat merged commit b4a4a98 into master Feb 15, 2019
@tmat tmat deleted the update-publishdata branch April 9, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants