Merge master to features/readonly-members #33485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name for the named pipe used between MSBuild and VBCSCompiler is generated from a combination of values including the current user name, specifically `%USERNAME%`. It is possible for this value to have spaces in it and hence the argument must be quoted when passing it to the command line of VBCSCompiler instances. Regression initially introduced: #32257
Ensure pipename argument quoted
Merge dev16.0 to master
… than HashSize (#33363) * replace SHA1 to SHA256 * tweak * Update src/Workspaces/Core/Portable/Workspace/Solution/Checksum.cs Co-Authored-By: heejaechang <heejaechang@outlook.com> * Update src/Workspaces/Core/Portable/Workspace/Solution/Checksum.cs Co-Authored-By: heejaechang <heejaechang@outlook.com> * Update src/Workspaces/Core/Portable/Workspace/Solution/Checksum.cs Co-Authored-By: heejaechang <heejaechang@outlook.com> * tweaks based on PR feedback * removed unnecessary unsafe * updated comment * moved comments around and removed reference to SHA in checksum
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/readonly-members.
git fetch --all git checkout merges/master-to-features/readonly-members git reset --hard upstream/features/readonly-members git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/readonly-members --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.