pool incrementalHash so that we don't create one unnecessarily #33496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
approved these changes
Feb 19, 2019
| @@ -14,41 +15,44 @@ namespace Microsoft.CodeAnalysis | |||
| // all these are just helper methods | |||
| internal partial class Checksum | |||
| { | |||
| private static readonly ObjectPool<IncrementalHash> s_objectPool = | |||
There was a problem hiding this comment.
💡 Consider using a more specific name for this pool field
|
tagging @dotnet/roslyn-ide |
| @@ -14,41 +15,44 @@ namespace Microsoft.CodeAnalysis | |||
| // all these are just helper methods | |||
| internal partial class Checksum | |||
| { | |||
| private static readonly ObjectPool<IncrementalHash> s_incrementalHashPool = | |||
| new ObjectPool<IncrementalHash>(() => IncrementalHash.CreateHash(HashAlgorithmName.SHA1), size: 20); | |||
There was a problem hiding this comment.
no particular reason. other pool uses 20 so, it uses 20 as well.
| stream.Seek(0, SeekOrigin.Begin); | ||
| stream.Seek(0, SeekOrigin.Begin); | ||
|
|
||
| var hash = pooledHash.Object; |
There was a problem hiding this comment.
does anything need to reset this, either before/after using it?
There was a problem hiding this comment.
hash got reset when it get into the pool
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
save cost of creating new incremental hash.