Merge master to features/readonly-members #33571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to use SymbolFinder.OriginalSymbolsMatch. SymbolFinder.OriginalSymbolsMatch has heuristics to determine if types are the same even if coming from a different assembly. This helps in cases where GoToImplementation needs to resolve across projects that get types like System.Threading.Tasks.Task from different assemblies, but are equivalent and fulfill requirements for interface implementation.
Despite all the effort to free-thread all our ruleset handling around file change notifications, we forgot to actually subscribe to the file change notifications. This fixes that. This also adds a unit test to cover this. Unfortunately getting the tests to work require a few hacks right now, as there's some workarounds for old (and no longer applicable) problems. I've filed #33506 to fix those and plan to do so, just not in a branch where riskier changes aren't welcome. Fixes #33465.
This call only works when the tests are run as an administrator. For local testing, the call will always fail because the tests run as a normal user. For CI testing, the call is simply unnecessary because the machines are not connected to physical input devices (keyboard/mouse) that would be otherwise able to interfere with the test sequence.
Integration tests require active focus, so we set it there before SendInput calls and allow it to stay there.
Merge dev16.0 to master
SendInput using scan codes when available
…hanging Subscribe to and process rule set file changes
Fix up all the test project launchSettings.json to allow F5 again
…n_broken Update the FindImplementationsForInterfaceMember
Revert "set no activation context on provisional tab when navigate to"
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/readonly-members.
git fetch --all git checkout merges/master-to-features/readonly-members git reset --hard upstream/features/readonly-members git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/readonly-members --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.