added ability to clear all diagnostics reproted from a IDiagnosticUpd… #33805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ateSource previously IDiagnosticUpdateSource has to clear each diagnostics it reported group by group. that was fine for IDiagnosticUpdateSource that supports incremental update, but some source such as EditAndContinue doesn't support incremental update since their errors (emit errors) come and go as a bulk (whole project). when they update, they need to update everything. so tracking things in group for incremental update is unnecessary for such source. the new API (Source.Cleared) make it easy for source to clear all diagnostics at once it produced.
|
tagging @tmat you just need to raise encUpdateSource.Cleared?.Invoke(this, EventArgs.Empty) to clear all diagnostics reported from your source. |
|
tagging @dotnet/roslyn-ide |
tmat
reviewed
Mar 2, 2019
| { | ||
| using (var workspace = new TestWorkspace(TestExportProvider.ExportProviderWithCSharpAndVisualBasic)) | ||
| { | ||
| var set = new ManualResetEvent(false); |
There was a problem hiding this comment.
set [](start = 20, length = 3)
set is an odd name for an event.
There was a problem hiding this comment.
so.. wait handle then?
tmat
reviewed
Mar 2, 2019
| private void RaiseDiagnosticsCleared(object sender) | ||
| { | ||
| Contract.ThrowIfNull(sender); | ||
| var source = (IDiagnosticUpdateSource)sender; |
There was a problem hiding this comment.
I'd move this to the caller and strongly type the parameter.
tmat
reviewed
Mar 2, 2019
| @@ -150,12 +181,48 @@ private bool UpdateDataMap(IDiagnosticUpdateSource source, DiagnosticsUpdatedArg | |||
| } | |||
| } | |||
|
|
|||
| private bool ClearDiagnosticsFromDataMapFor(IDiagnosticUpdateSource source, List<DiagnosticsUpdatedArgs> removed) | |||
There was a problem hiding this comment.
ClearDiagnosticsFromDataMapFor [](start = 21, length = 30)
Wouldn't ClearDiagnosticsReportedBySource be better name?
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 4, 2019
* dotnet/master: (903 commits) Add UseEnhancedColors to FeatureOnOffOptionsProvider (dotnet#33802) Update TypeStyle.cs Text on a InterpolatedVerbatimStringStartToken token (dotnet#33747) added ability to clear all diagnostics reproted from a IDiagnosticUpd… (dotnet#33805) Use a set instead of map to define processed redundant nodes. EnC: Remove dependency on solution from AnalyzeDocumentAsync (dotnet#33796) Add workitem links to new redundant assignment tests. Move leading trivia with node when removing unused values. Remove OOP related feature options. (dotnet#31644) Merge pull request dotnet#33631 from CyrusNajmabadi/wrapPriority Use the correct iteration count in IterationDataAttribute Handle interface members in NullableWalker.AsMemberOfType (dotnet#33764) Cleanly work around microsoft/nodejstools#2138 Implement full spec changes for Index/Range (dotnet#33679) Further reduce expectations on deep fluent calls Lower expectation for deep fluent call Take screenshot after writing logs Avoid throwing exception in static constructor Offer to add parameter to constructor with no existing parameters (dotnet#33624) Add regression test for nullable crash (dotnet#33735) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ateSource
previously IDiagnosticUpdateSource has to clear each diagnostics it reported group by group. that was fine for IDiagnosticUpdateSource that supports incremental update, but some source such as EditAndContinue doesn't support incremental update since their errors (emit errors) come and go as a bulk (whole project). when they update, they need to update everything. so tracking things in group for incremental update is unnecessary for such source.
the new API (Source.Cleared) make it easy for source to clear all diagnostics at once it produced.