Merge 'dotnet/master' into DefaultInterfaceImplementation #33808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark Roslyn.VisualStudio.DiagnosticsWindow as a build dependency…
Now that we have the version of arcade that supports Microsoft.Net.Compilers.Toolset we can remove a few work arounds.
Marshal.SizeOf is not a direct replacement for `sizeof` and the issues around it are subtle. Fix dotnet#26513
I verified that this test crashes the compiler in Preview3 but no longer repros. Fixes dotnet#33537
…tnet#33624) * Fixes 33602 * respond to comments
Undo arcade work arounds
VisualStudioInstanceFactory failures now occur in a context where they are reported as test failures instead of test runner crashes.
This change ensures that logs are created even if the application fails to capture a screenshot.
…lablewalker-to-use-a-two-state-solution
Reflects the changes described in dotnet/csharplang#2214. Range now looks optimistically for some special members with optional parameters, but will fall back to the Range constructor if they aren't present. This change also removes all of the specialized codegen that was going on with arrays and strings in favor of expected helpers or real members.
Revise NullableWalker to use a two-state solution
Delayed failures in integration tests
Allow specific exception without crash in integration tests
Merge dev16.0 to master
* Enable OOP features by default. * Removing unused function. * conflicts
AlekseyTs
added
the
PR For Personal Review Only
AlekseyTs
added
Area-Compilers
Feature - Default Interface Impl
RikkiGibson
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.