Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments for already-resolved github issues. #33880

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Remove comments for already-resolved github issues. #33880

merged 1 commit into from
Mar 6, 2019

Conversation

gafter
Copy link
Member

@gafter gafter commented Mar 5, 2019

See also #28798, #32047, #33879
Closes #29953

@gafter gafter added Area-Compilers PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. New Language Feature - Nullable Reference Types Nullable Reference Types labels Mar 5, 2019
@gafter gafter added this to the 16.1.P1 milestone Mar 5, 2019
@gafter gafter self-assigned this Mar 5, 2019
@gafter gafter removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Mar 6, 2019
@gafter gafter marked this pull request as ready for review March 6, 2019 01:25
@gafter gafter requested a review from a team as a code owner March 6, 2019 01:25
@gafter gafter requested a review from a team March 6, 2019 17:58
jcouv
jcouv approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@gafter gafter merged commit 88c4dca into dotnet:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

Assignees

@gafter gafter

Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
None yet
Milestone
16.1.P1
Development

Successfully merging this pull request may close these issues.
3 participants
@gafter @cston @jcouv