Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly members emit changes #33954

Merged
merged 7 commits into from
Mar 11, 2019
Merged

Readonly members emit changes #33954

merged 7 commits into from
Mar 11, 2019

Conversation

RikkiGibson
Copy link
Contributor

Related to #32911

  • fill out implementations for MethodSymbol.IsReadOnly
  • create a temp receiver when calling a non-readonly method from a readonly method
  • share this without value copying when calling a readonly method from a readonly method

@RikkiGibson RikkiGibson requested a review from a team as a code owner March 7, 2019 23:57
@RikkiGibson RikkiGibson modified the milestones: 16.1, 16.1.P1 Mar 8, 2019
@sharwell
Copy link
Member

sharwell commented Mar 8, 2019

Integration test failure caused by #33856; restarting the run

@jaredpar
Copy link
Member

Done with review pass (iteration 5)

jaredpar
jaredpar approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RikkiGibson RikkiGibson reopened this Mar 11, 2019
@RikkiGibson
Copy link
Contributor Author

FYI @sharwell there were integration test failures:

Errors Microsoft.VisualStudio.LanguageServices.IntegrationTests.dll
    Roslyn.VisualStudio.IntegrationTests.VisualBasic.BasicAddMissingReference.VerifyAvailableCodeActions [FAIL]
    Roslyn.VisualStudio.IntegrationTests.VisualBasic.BasicAddMissingReference.InvokeSomeFixesInVisualBasicThenVerifyReferences [FAIL]
    Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpExtractMethod.ExtractViaCodeAction [FAIL]
    Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpNavigationBar.VerifyNavBar [FAIL]

@RikkiGibson RikkiGibson merged commit 695ca5c into dotnet:features/readonly-members Mar 11, 2019
@RikkiGibson RikkiGibson deleted the readonly-members-copy-receiver branch March 11, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agocke agocke agocke left review comments

@VSadov VSadov VSadov approved these changes

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
16.1.P1
Development

Successfully merging this pull request may close these issues.
5 participants
@RikkiGibson @sharwell @jaredpar @agocke @VSadov