Offer add parameter to constructor refactoring for all applicable constructors #34041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chborl
changed the title
|
@chborl can you update your title to be clearer? Which feature is this for, for example. |
...eFromMembers/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.cs
Show resolved
Hide resolved
...eFromMembers/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.cs
Outdated
Show resolved
Hide resolved
...eFromMembers/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.cs
Outdated
Show resolved
Hide resolved
...onstructorParametersFromMembersCodeRefactoringProvider.AddConstructorParametersCodeAction.cs
Outdated
Show resolved
Hide resolved
...onstructorParametersFromMembersCodeRefactoringProvider.AddConstructorParametersCodeAction.cs
Show resolved
Hide resolved
...onstructorParametersFromMembersCodeRefactoringProvider.AddConstructorParametersCodeAction.cs
Outdated
Show resolved
Hide resolved
...onstructorParametersFromMembersCodeRefactoringProvider.AddConstructorParametersCodeAction.cs
Outdated
Show resolved
Hide resolved
...onstructorParametersFromMembersCodeRefactoringProvider.AddConstructorParametersCodeAction.cs
Outdated
Show resolved
Hide resolved
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Show resolved
Hide resolved
chborl
changed the title
|
@CyrusNajmabadi, can you take another look? Thanks :) |
JoeRobich
reviewed
Mar 14, 2019
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: chborl <chborl@users.noreply.github.com>
Co-Authored-By: chborl <chborl@users.noreply.github.com>
…into deserializationctor
sharwell
requested changes
Mar 15, 2019
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...torParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.State.cs
Outdated
Show resolved
Hide resolved
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...eFromMembers/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.cs
Outdated
Show resolved
Hide resolved
...eFromMembers/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: chborl <chborl@users.noreply.github.com>
Co-Authored-By: chborl <chborl@users.noreply.github.com>
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Show resolved
Hide resolved
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
|
stopping review. this looks like this still needs a pass by @chborl first to deal with the existing feedback. |
|
@sharwell and @CyrusNajmabadi for review. Thanks :) |
sharwell
reviewed
Mar 21, 2019
...eFromMembers/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.cs
Show resolved
Hide resolved
...eFromMembers/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.cs
Outdated
Show resolved
Hide resolved
...nstructorParametersFromMembers/AddConstructorParametersFromMembersCodeRefactoringProvider.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: chborl <chborl@users.noreply.github.com>
Co-Authored-By: chborl <chborl@users.noreply.github.com>
sharwell
approved these changes
Mar 25, 2019
...ualBasicTest/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.vb
Outdated
Show resolved
Hide resolved
...ualBasicTest/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.vb
Outdated
Show resolved
Hide resolved
...ualBasicTest/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.vb
Outdated
Show resolved
Hide resolved
...ualBasicTest/AddConstructorParametersFromMembers/AddConstructorParametersFromMembersTests.vb
Outdated
Show resolved
Hide resolved
Update doc comment Co-Authored-By: chborl <chborl@users.noreply.github.com>
|
Apologies if I missed an existing conversation on this, but should we need to limit 1) The number of constructors listed in these submenus, or 2) The length of the constructor symbol display? |
@dpoeschl , here is a screenshot with 16 constructors: The width of the sub menu is limited with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33603
Fixes #33623
When one or more members are selected, user can Ctrl+. to add them as parameters to any applicable parameter. If more that one constructor is applicable, suggested actions will be nested under 2 menu items, "Add parameter to constructor" and "Add optional parameter to constructor"
In addition, this PR ensures parameters will not be offered for deserialization constructors.