Adjust base access with explicit base according to latest LDM decisions #34121
Conversation
- Restrict accessed members to immediate members of the specified type. - Change accessibility of explicit implementations in interfaces to ‘protected’.
AlekseyTs
added
the
Feature - Default Interface Impl
|
@dotnet/roslyn-compiler Please review |
|
Looks like a transient failure in Windows_Desktop_Spanish_Unit_Tests? |
The 4 CI jobs are expected to fail due to infrastructure issues |
|
@dotnet/roslyn-compiler Please review |
We plan to try supporting these scenarios in the future, it will be a lot easier to convert to success checks if the code is preserved. In reply to: 473093270 [](ancestors = 473093270) Refers to: src/Compilers/CSharp/Test/Symbol/Symbols/DefaultInterfaceImplementationTests.cs:55597 in af91c73. [](commit_id = af91c73, deletion_comment = False) |
| return true; | ||
| } | ||
| } | ||
| else if (!checkOnlyAccessThroughInterface && method.IsAbstract) | ||
|
|
||
| if (member.IsAbstract) |
There was a problem hiding this comment.
if (member.IsAbstract) [](start = 16, length = 22)
There was no impact of removing checkOnlyAccessThroughInterface (used to be set for assigning to base event)? Feels like we're producing an extra diagnostic. #Resolved
There was a problem hiding this comment.
There was no impact of removing checkOnlyAccessThroughInterface (used to be set for assigning to base event)? Feels like we're producing an extra diagnostic.
That was compensated by the change in Binder.CheckEventValueKind
In reply to: 266171739 [](ancestors = 266171739)
We plan to try supporting these scenarios in the future, it will be a lot easier to convert to success checks if the code is preserved. In reply to: 473471717 [](ancestors = 473471717) Refers to: src/Compilers/CSharp/Test/Symbol/Symbols/DefaultInterfaceImplementationTests.cs:42971 in af91c73. [](commit_id = af91c73, deletion_comment = False) |
Relates to LDM notes: https://github.com/dotnet/csharplang/blob/master/meetings/2019/LDM-2019-02-27.md#collision-of-lookup-rules-and-decisions-for-base
Related to #32054.