-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent embedding of interfaces that contain non-abstract members. #34171
Prevent embedding of interfaces that contain non-abstract members. #34171
Conversation
Diagnostic(ErrorCode.ERR_DefaultInterfaceImplementationInNoPIAType, "ITest33").WithArguments("ITest33").WithLocation(6, 13) | ||
); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be interesting to test this combination:
ITest33 with method declaration. ITest34 inerits ITest33, implements the method. UsePia test with both ITest33 and ITest34. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be interesting to test this combination:
ITest33 with method declaration. ITest34 inerits ITest33, implements the method. UsePia test with both ITest33 and ITest34.
Added tests.
In reply to: 266136460 [](ancestors = 266136460)
|
||
[ComImport()] | ||
[Guid(""f9c2d51d-4f44-45f0-9eda-c9d599b58279"")] | ||
public interface ITest33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth testing an interface with a nested type (interface or abstract class), since they are new scenarios? Looks like we expect an error for that (ERR_NoPIANestedType). #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth testing an interface with a nested type (interface or abstract class), since they are new scenarios? Looks like we expect an error for that (ERR_NoPIANestedType).
These are not new scenarios because VB supports types nested in interfaces. The ERR_NoPIANestedType is also covered in NoPia_06
.
In reply to: 266158754 [](ancestors = 266158754)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (commit 2)
No description provided.