Fix build correctness #34421
Merged
Fix build correctness #34421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
force-pushed
the
fix-build
branch
2 times, most recently
from
05b70d8 to
01d5b59
Compare
|
@dotnet/roslyn-infrastructure for review |
jasonmalinowski
approved these changes
Mar 27, 2019
The project which deploys ILASM tools ends up bringing two runtime packages that have the same assets: - runtime.win-x64.microsoft.netcore.runtime.coreclr - runtime.win-x64.microsoft.netcore.app Specifically assets like SOS.NetCore.dll exists at different versions in these packages and end up getting copied twice to the output directory. This double write ends up breaking our build (as well as basic isolation). The short term fix here is to no longer treat this as a code project but instead a tools project. That eliminates the MS.NetCore.app package and the associated double writes Long term though the root issue needs to be addressed: making ilasm and ildasm easier to deploy. https://github.com/dotnet/coreclr/issues/15059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project which deploys ILASM tools ends up bringing two runtime
packages that have the same assets:
Specifically assets like SOS.NetCore.dll exists at different versions in
these packages and end up getting copied twice to the output directory.
This double write ends up breaking our build (as well as basic
isolation).
The short term fix here is to no longer treat this as a code project but
instead a tools project. That eliminates the MS.NetCore.app package and
the associated double writes
Long term though the root issue needs to be addressed: making ilasm and
ildasm easier to deploy.
dotnet/coreclr#15059