Remove PROTOTYPE comments and fix formatting warnings #34475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/roslyn-compiler Please review |
AlekseyTs
added
the
Feature - Default Interface Impl
|
@dotnet/roslyn-compiler Please review |
cston
reviewed
Mar 27, 2019
| // the message should be adjusted. Should also check diagnostics for an attempt | ||
| // to implement other sealed members. | ||
| // https://github.com/dotnet/roslyn/issues/34455: The wording "accessor not found in interface member" is somewhat misleading | ||
| // in this scenario. The accessor is there, but cannot be implemented. Prehaps |
There was a problem hiding this comment.
Prehaps [](start = 130, length = 7)
Typo
There was a problem hiding this comment.
Typo
This is a preexisting condition, the entire comment will be removed once the referenced issue is addressed.
cston
approved these changes
Mar 27, 2019
|
@dotnet/roslyn-compiler Please review, need a second sign-off |
|
@dotnet/roslyn-compiler Please review, need a second sign-off for a very small change |
jaredpar
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.