Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification for VS.ExternalAPIs.Roslyn package #34546

Merged
merged 3 commits into from
Mar 28, 2019

Conversation

jaredpar
Copy link
Member

A recent refactoring caused a number of insertion failures as we weren't
properly updating the contents of VS.ExternalAPIs.Roslyn.nupkg. This
adds basic verification that the contents are correct based on our build
output.

A recent refactoring caused a number of insertion failures as we weren't
properly updating the contents of VS.ExternalAPIs.Roslyn.nupkg. This
adds basic verification that the contents are correct based on our build
output.
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredpar jaredpar merged commit 7cb5a0c into dotnet:master Mar 28, 2019
@jaredpar jaredpar deleted the fix-verify branch March 28, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants