-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readonly members more test coverage #34602
Readonly members more test coverage #34602
Conversation
Did you do an IDE test pass to identify what works and what doesn't? It's generally ok to file issues, except for few blockers: mostly crashes, annoying completion (ie. you can't type what you want and have to fight against the IDE), or any really annoying behavior. |
Sounds good.
I would file individual issues. That isn't blocking the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (iteration 5) with one test suggestion
This PR contains test coverage additions mainly from the test plan review we had yesterday.
int P readonly => 42;
readonly
keyword on an accessor (this matches the behavior with accessibility modifiers)This is the last work I expect to do before finally merging master into this branch, and then integrating this branch into master.