Remove the term "whitelist" #3507

tmeschter · 2015-06-15T19:51:48Z

Note that this fix has been to ship room before and was approved (request #3457); I then discovered I had created the pull request against master instead of stabilization. This is the same change, against stabilization.

Bug: Fixes DevDiv Bug 1185799

Customer Scenario
No customer scenario, per se.

There are a number of places where we use the term "whitelist", and one of them (a code comment) was flagged by Policheck. Given that our code is open I've gone ahead and simply fixed them all.

Fix
Several internal types were updated with new names, as well as various fields, locals, and a comment.

Testing
After the fix, the code still passes all of our unit and integration tests.

@ManishJayaswal This is ready to go to ship room.

We have a couple of places where we check that the set of analyzer assemblies is internally consistent and complete--that is, for any given assembly in that set, all of its dependencies are satisfied by other assemblies in the set. We expect certain dependencies to be satisfied by the host, and so want to ignore them if they are not found in the the analyzer assembly set. We referred to these host-provided dependencies as a white list, but Policheck does not like that term. Instead, we now refer to these as the "ignorable assembly list".

srivatsn · 2015-06-15T19:53:48Z

👍

ManishJayaswal · 2015-06-15T19:54:43Z

Approved on 6/15 by ML Shiproom. This was already approved in a PR against master #3457

Remove the term "whitelist" **Bug:** Fixes DevDiv Bug 1185799 **Customer Scenario** No customer scenario, per se. There are a number of places where we use the term "whitelist", and one of them (a code comment) was flagged by Policheck. Given that our code is open I've gone ahead and simply fixed them all. **Fix** Several internal types were updated with new names, as well as various fields, locals, and a comment. **Testing** After the fix, the code still passes all of our unit and integration tests.

MartinJohns · 2016-06-15T19:21:35Z

I found the word whitespace 345 times in the code base. Will you remove that too?

sjmcallister · 2016-06-15T20:53:21Z

I can't even...why is this a thing?

ikrastev · 2016-06-15T21:09:27Z

This is wrong on so many levels. We are programmers, not politicians ffs!

crowell · 2016-06-15T22:35:33Z

at the risk of stirring up a hornets nest, ignorelist is quite possibly one of the worst names for whitelist/blacklist. Does ignore mean allow, or does ignore mean deny. In this case it seems like you've used ignorelist to mean whitelist, which totally doesn't make sense to me.

I'd propose blocklist and acceptlist or similar if I were looking for a replacement for whitelist/blacklist.

indualagarsamy · 2016-06-16T01:47:10Z

Totally agree with @crowell. IMO, blocklist and acceptlist is much better replacement. It also specifies the intent much more clearly than calling it whitelist or blacklist.

shiitake · 2016-06-16T02:47:38Z

Agree with @crowell and @indualagarsamy. Clarity ftw.

Sajgoniarz · 2016-06-16T14:44:27Z

Seriously? It smells like racism bullsh*t for me. Black and whitelist words have a way different etymology. In my language translating whitelist or black list to block or accept list will be nice and long joke.

casper · 2016-06-16T15:16:28Z

Blocklist!? No way. Now that is offensive. My dad used to be a factory worker making blocks. You making fun of blocks now too with your "programming" skills?

Actually it seems discriminating to "allow", "block", or "ignore" anything. This shit needs to be completely removed from modern day software. Things like firewalls make my blood boil. Discriminating network packets and the free flow of digital data. You programmers. It's inexcusable how you're getting away with this behavior.

cubuspl42 · 2016-06-16T15:50:41Z

Instead of fixing the compiler, you should just whitelist whitelist in that wonderful "policheck" tool.

morsik · 2016-06-16T16:19:30Z

Why you're so racist and removing things with word "white"? :>

Mapiarz · 2016-06-16T17:00:44Z

I totally agree. Additionally, I think we should remove static typing. We shouldn't be telling objects what they are until they decide for themselves, at runtime. Segregating objects based on type? I think I've heard that before...

ghost · 2016-06-16T17:28:25Z

I am feeling offended by anyone offended by word such as "blacklist", "master-slave". Please check your privilege and reconsider your priorities.

keiosweb · 2016-06-16T17:32:36Z

great job, now it's time for https://github.com/torvalds/linux/search?p=1&q=blacklist&utf8=%E2%9C%93 please do, I want to see that.

qrlpx · 2016-06-16T17:55:06Z

👍 by me.

This backlash by angry brogrammers was to be expected. It's like you just wait all day to find something to throw a temper tantrum about.

Your lingo might have been ok back in the day, but nowadays we actually care about being mindful about each others backgrounds. If someone tells you that the words you're using are not ok, just be nice and don't use them, it's that simple. Our language changes, all the time, deal with it.

MrMetric · 2016-06-16T18:02:51Z

@quizix You're the ones finding something to be angry about. There is no need to change terminology here.

khellang · 2016-06-16T18:08:14Z

Folks... this is a 1 year old PR. Let's just leave it. It's silly, but that's the way it is.

lbialy · 2016-06-16T21:32:42Z

If someone tells you that the words you're using are not ok, just be nice and don't use them, it's that simple.

Comply, comply!

@quizlx This isn't a change of words that are widely regarded as offensive. This is a blanket ban on words that have no relation to anything remotely offensive to any sane person. Etymology does not hint any racial load neither: https://en.wikipedia.org/wiki/Blacklisting so why is language gutted?

casper · 2016-06-16T21:47:14Z

@quizlx @lbialy

This isn't a change of words that are widely regarded as offensive.

You make exactly the right point. Words like master-slave, whitelisting, blacklisting have been used by programmers for decades. Way before most people here were even born. They were never even remotely intended to be used for anything else than conveying technical information, and getting the job done. No sinister thought or offensive idea even crossed the minds of the people using these terms. They are de-facto standard words used to describe technical computing terms, nothing else.

Now here then comes a group from the so called generation snowflake, and they MAKE UP meaning where none was before, and then after they establish what they think is the new meaning they start to demand change.

It is as if I would suddenly start to accuse Github for designing this website with black text on white background. Is Github insinuating something with this color scheme? Black on white? Imagine the shitstorm we could raise demanding that black text on white background has to be banned, because I came up with this offensive meaning for this type of color scheme.

This whole PC trend in programming is an entirely made up fairy tale by some people who cannot find any other way to contribute constructively to society. It's easier to control people by telling them things that need to be done and changed, than to do something constructive yourself. Make up your own fantasy, and impose it on everyone else.

dchem · 2016-06-16T23:34:48Z

Policheck lol

houbaron · 2016-06-17T01:29:32Z

In ancient China, there was a crime called “Literary inquisition”. It was designed by government to make people to shut up.After about 300 years, Chinese citizens had revoluted for so many times.But we haven't get rid of it.Today I found the Literary inquisition exist in free countries,too.

marblu · 2016-06-17T04:09:09Z

left-handed wanna say： STOP using Right/LEFT to stand for what is good/the rest

EdiWang · 2016-06-17T13:10:37Z

可以，这很清真

qrlpx · 2016-06-17T13:17:32Z

@lbialy

Etymology does not hint any racial load neither: https://en.wikipedia.org/wiki/Blacklisting

It doesn't need to.
What matters is how certain words are perceived, right now, in the present. And you people are doing a swell job politicizing them, good work.

@casper

Words like master-slave, whitelisting, blacklisting have been used by programmers for decades. Way before most people here were even born.

And in the past, it was completly acceptable for people to use the label "n*gro". It had a different meaning back then, even MLK used it. Would you argue that for this reason, it is not offensive today? Go ahead then, use it. Use it and see how people react.

@houbaron

In ancient China, there was a crime called “Literary inquisition”.

Except duh Microsoft changed the wording out of their own volition.
Everything was fine and dandy. Nobody has been hold a gun to the head, nobody has been threatened, nobody has been dogpiled like you're doing right now.... in fact, at this moment, it seems that you people are the only ones policing others. How quick the tide turns, huh?

houbaron · 2016-06-17T13:43:52Z

@quizlx I am from China.So my English is poor. I think you may misunderstand me. The "Literary inquisition" is a crime which was designed by gov. People whose words touch the gov's weakness will be throwed into jail. The "Literary inquisition" often happen in some tiny places, like homophonic, spell & double meaning. Nobody like Racial Discrimination. Asian sometimes are victims, too. But the white-list is just a nickname. People who designed such words may be not intentional. In China, there is a kind of website called yellow page. No body think they are making fun of yellow skin Asian. Even in China, yellow represents porn.

condret · 2016-06-21T23:33:23Z

next: remove the master-branch. It implies that there could be a slave-branch. So having a master-branch is a potential sign for supporting slavery.

Seriously, wake up! All this sjw-code-of-conduct-stuff is totally nonsense. Pls spend you time on fixing real bugs instead.

ghost · 2016-06-22T09:26:38Z

Note how cultural marxists never want to create their own software and communities.Instead they want to police and control software created by others, under the guise of "inclusivity".

deeterius · 2016-06-22T14:54:19Z

I have a counterproposal, for the sake of clarity and better representation for ethnic minorities. Rename whitelist to 'supremepalegoodgoys' and blacklist to 'untermenchafrosemitics'. Will any of the people with commit bits back this proposal ?

Hail Hydra

pHr34kY · 2017-02-15T10:44:17Z

Perhaps denylist / allowlist? block/accept seems clumsy.

TBH I would have left it as blacklist/whitelist because it's commonly used and understood, and clarity trumps everything when writing shared code.

yarwest · 2017-02-15T12:16:15Z

@pHr34kY why are you even taking this seriously?

coquer · 2017-02-15T15:43:10Z

Why did this got approved, is a non sense issue... we are programmers not policial class people so we do not need to be sensible to some but hurt people for a word... is a word!!!

galenguyer · 2017-02-15T16:27:24Z

This change makes no sense simply because of the clarity you're trying to preserve. The commonly accepted term for a list of people who can't use something is called a blacklist. Changing the term destroys the lingo that has been developed, and now people looking at your code from an outsiders view who haven't seen this pull.
However, I accept your freedom to do this, it's one of the greatest things about America. Additionally, please remove the "master" branch, this implies that it is greater than the other branches, which is very unfair to them. Thank you, a concerned programmer.

moopie · 2017-02-15T17:13:50Z

ITT: people who never touched this project suddenly have some strong words to say in yet another pointless "I AM OFFENDED BY THIS" drama

drama people pls go

x89 · 2017-02-15T17:23:03Z

@moopie 👌👌👌👌👌

IDisposable · 2017-02-15T17:50:48Z

src/Compilers/Core/VBCSCompiler/AnalyzerConsistencyChecker.cs

@@ -12,19 +12,19 @@ namespace Microsoft.CodeAnalysis.CompilerServer
 {
    internal static class AnalyzerConsistencyChecker
    {
-        private static readonly ImmutableArray<string> s_defaultWhiteList = ImmutableArray.Create("mscorlib", "System", "Microsoft.CodeAnalysis");
+        private static readonly ImmutableArray<string> s_defaultIgnorableReferenceNames = ImmutableArray.Create("mscorlib", "System", "Microsoft.CodeAnalysis");


please change to s_defaultSafeReferenceNames

IDisposable · 2017-02-15T17:51:05Z

src/Compilers/Core/VBCSCompiler/AnalyzerConsistencyChecker.cs


-        public static bool Check(string baseDirectory, IEnumerable<CommandLineAnalyzerReference> analyzerReferences, IAnalyzerAssemblyLoader loader, IEnumerable<string> referenceWhiteList = null)
+        public static bool Check(string baseDirectory, IEnumerable<CommandLineAnalyzerReference> analyzerReferences, IAnalyzerAssemblyLoader loader, IEnumerable<string> ignorableReferenceNames = null)


please change to safeReferenceNames

morsik · 2017-02-15T17:52:51Z

@moopie: cause software development is not about political corectness. This is not right or wrong. This is just strange what's happened in this commit!

And yeah. We can say we are offended by this, like author can say he's offended by words "Whitelist" and "Blacklist" that were used in IT for years.

IDisposable

Should really rename to the meaning intended (not ignore but skip or accept or reject)

IDisposable · 2017-02-15T17:51:17Z

src/Compilers/Core/VBCSCompiler/AnalyzerConsistencyChecker.cs

        {
-            if (referenceWhiteList == null)
+            if (ignorableReferenceNames == null)


please change to safeReferenceNames

IDisposable · 2017-02-15T17:51:31Z

src/Compilers/Core/VBCSCompiler/AnalyzerConsistencyChecker.cs

            {
-                referenceWhiteList = s_defaultWhiteList;
+                ignorableReferenceNames = s_defaultIgnorableReferenceNames;


please change to safeReferenceNames

IDisposable · 2017-02-15T17:51:43Z

src/Compilers/Core/VBCSCompiler/AnalyzerConsistencyChecker.cs

            }

            try
            {
                CompilerServerLogger.Log("Begin Analyzer Consistency Check");
-                return CheckCore(baseDirectory, analyzerReferences, loader, referenceWhiteList);
+                return CheckCore(baseDirectory, analyzerReferences, loader, ignorableReferenceNames);


please change to safeReferenceNames

IDisposable · 2017-02-15T17:51:54Z

src/Compilers/Core/VBCSCompiler/AnalyzerConsistencyChecker.cs

@@ -37,7 +37,7 @@ public static bool Check(string baseDirectory, IEnumerable<CommandLineAnalyzerRe
            }
        }

-        private static bool CheckCore(string baseDirectory, IEnumerable<CommandLineAnalyzerReference> analyzerReferences, IAnalyzerAssemblyLoader loader, IEnumerable<string> referenceWhiteList)
+        private static bool CheckCore(string baseDirectory, IEnumerable<CommandLineAnalyzerReference> analyzerReferences, IAnalyzerAssemblyLoader loader, IEnumerable<string> ignorableReferenceNames)


please change to safeReferenceNames

IDisposable · 2017-02-15T17:52:06Z

src/Compilers/Core/VBCSCompiler/AnalyzerConsistencyChecker.cs

            foreach (var resolvedPath in resolvedPaths)
            {
                var missingDependencies = AssemblyUtilities.IdentifyMissingDependencies(resolvedPath, resolvedPaths);

                foreach (var missingDependency in missingDependencies)
                {
-                    if (!referenceWhiteList.Any(name => missingDependency.Name.StartsWith(name)))
+                    if (!ignorableReferenceNames.Any(name => missingDependency.Name.StartsWith(name)))


please change to safeReferenceNames

IDisposable · 2017-02-15T17:53:53Z

src/VisualStudio/Core/Def/Implementation/AnalyzerDependencyChecker.cs

        private readonly IBindingRedirectionService _bindingRedirectionService;

-        public AnalyzerDependencyChecker(IEnumerable<string> analyzerFilePaths, IEnumerable<IAssemblyWhiteList> assemblyWhiteLists, IBindingRedirectionService bindingRedirectionService = null)
+        public AnalyzerDependencyChecker(IEnumerable<string> analyzerFilePaths, IEnumerable<IIgnorableAssemblyList> ignorableAssemblyLists, IBindingRedirectionService bindingRedirectionService = null)


please change to IEnumerable<ISkippableAssemblyList> skippableAssemblyList

IDisposable · 2017-02-15T17:54:57Z

src/VisualStudio/Core/Def/Implementation/AnalyzerDependencyChecker.cs

        {
            Debug.Assert(analyzerFilePaths != null);
-            Debug.Assert(assemblyWhiteLists != null);
+            Debug.Assert(ignorableAssemblyLists != null);


please change to skippableAssemblyList

IDisposable · 2017-02-15T17:55:33Z

src/VisualStudio/Core/Def/Implementation/AnalyzerDependencyChecker.cs


            _analyzerFilePaths = new HashSet<string>(analyzerFilePaths, StringComparer.OrdinalIgnoreCase);
-            _assemblyWhiteLists = assemblyWhiteLists.ToList();
+            _ignorableAssemblyLists = ignorableAssemblyLists.ToList();


please change to _skippableAssemblyList = skippableAssemblyList.ToList()

IDisposable · 2017-02-15T17:56:20Z

src/VisualStudio/Core/Def/Implementation/AnalyzerDependencyChecker.cs

@@ -46,7 +46,7 @@ public AnalyzerDependencyResults Run(CancellationToken cancellationToken = defau
                }
            }

-            _assemblyWhiteLists.Add(new AssemblyIdentityWhiteList(analyzerInfos.Select(info => info.Identity)));
+            _ignorableAssemblyLists.Add(new IgnorableAssemblyIdentityList(analyzerInfos.Select(info => info.Identity)));


please change to _skippableAssemblyList.Add(new SkippableAssemblyIdentityList(analyzerInfos.Select(info => info.Identity)));

IDisposable · 2017-02-15T17:57:24Z

src/VisualStudio/Core/Def/Implementation/AnalyzerDependencyChecker.cs

@@ -74,7 +74,7 @@ private ImmutableArray<MissingAnalyzerDependency> FindMissingDependencies(List<A
                        ? _bindingRedirectionService.ApplyBindingRedirects(reference)
                        : reference;

-                    if (!_assemblyWhiteLists.Any(whiteList => whiteList.Includes(redirectedReference)))
+                    if (!_ignorableAssemblyLists.Any(ignorableAssemblyList => ignorableAssemblyList.Includes(redirectedReference)))


please change to if (!_skippableAssemblyLists.Any(skippableAssemblyList => skippableAssemblyList.Includes(redirectedReference)))

This is stupid, everyone knows what whitelist means, and ignorableAssemblyList means nothing on the first read.

kromit · 2017-02-15T18:43:08Z

This PR is linked on /r/ProgrammerHumor hence the comments.

PR/merge worthy project here: https://github.com/ErisBlastar/cplusequality

jonahoffline · 2017-02-15T18:43:17Z

What about compiling to gender neutral non-binary bits instead?

codingducks · 2017-02-15T18:50:32Z

was thinking quacklist and honklist would be suitable

StevenGann · 2017-02-15T18:55:36Z

Can we replace all Booleans with floats as well? The reasoning is two-fold:

Bool and Boolean are named after George Boole, a white, straight, British male who lived in the 19th Century, the height of British and Western Colonialism and the oppression/genocide of people of color, i.e. everyone outside of Europe. Honoring him with a data type, let alone two, is an insult to aboriginal cultures everywhere.
Boolean variables are forced to be "True" or "False", implying that anything can be identified as objectively true or objectively false. This is a heteronormative, imperialistic Western philosophy and is the root of all racism, sexism, classism, ageism, speciesism, Fascism, neurotypicalism. Non-European cultures believe that everything is some combination of True AND False, and as a result had no hatred, warfare, discrimination, poverty, or starvation until European Imperialists showed up.

The obvious solution is to replace bools with floats.

(The above is satire, just to be perfectly clear.)

huysentruitw · 2017-02-15T18:58:23Z

@StevenGann PR underway!

tekguy · 2017-02-15T19:24:08Z

This is interesting, where can I find a copy of Policheck?

shiitake · 2017-02-15T20:33:34Z

@tekguy don't click on that above link! Completely NSFL!

If you do an internet search you can find a presentation on PoliCheck on prezi.com.

morsik · 2017-02-15T20:44:28Z

@tekguy: just don't search for that at all. Everyone will have better sleep.

tekguy · 2017-02-15T20:46:10Z

@shiitake ,

Thanks!

dnfclas added the cla-already-signed label Jun 15, 2015

tmeschter assigned MattGertz Jun 15, 2015

ManishJayaswal added the Approved to merge label Jun 15, 2015

tmeschter merged commit 345c3a6 into dotnet:stabilization Jun 15, 2015

tmeschter mentioned this pull request Jun 15, 2015

Remove the term "whitelist" #3457

Closed

dotnet locked and limited conversation to collaborators Jun 22, 2016

dotnet unlocked this conversation Jun 22, 2016

IDisposable reviewed Feb 15, 2017

View reviewed changes

This comment has been minimized.

Sign in to view

dotnet locked and limited conversation to collaborators Feb 15, 2017

jmarolf unassigned MattGertz May 18, 2019


		public static bool Check(string baseDirectory, IEnumerable<CommandLineAnalyzerReference> analyzerReferences, IAnalyzerAssemblyLoader loader, IEnumerable<string> referenceWhiteList = null)
		public static bool Check(string baseDirectory, IEnumerable<CommandLineAnalyzerReference> analyzerReferences, IAnalyzerAssemblyLoader loader, IEnumerable<string> ignorableReferenceNames = null)

Remove the term "whitelist" #3507

Remove the term "whitelist" #3507

Conversation

tmeschter commented Jun 15, 2015

srivatsn commented Jun 15, 2015

ManishJayaswal commented Jun 15, 2015

MartinJohns commented Jun 15, 2016 • edited Loading

sjmcallister commented Jun 15, 2016

ikrastev commented Jun 15, 2016

crowell commented Jun 15, 2016 • edited Loading

indualagarsamy commented Jun 16, 2016

shiitake commented Jun 16, 2016

Sajgoniarz commented Jun 16, 2016

casper commented Jun 16, 2016

cubuspl42 commented Jun 16, 2016

morsik commented Jun 16, 2016 • edited Loading

Mapiarz commented Jun 16, 2016

ghost commented Jun 16, 2016

keiosweb commented Jun 16, 2016

qrlpx commented Jun 16, 2016 • edited Loading

MrMetric commented Jun 16, 2016 • edited Loading

khellang commented Jun 16, 2016

lbialy commented Jun 16, 2016 • edited Loading

casper commented Jun 16, 2016 • edited Loading

dchem commented Jun 16, 2016

houbaron commented Jun 17, 2016

marblu commented Jun 17, 2016

EdiWang commented Jun 17, 2016

qrlpx commented Jun 17, 2016 • edited Loading

houbaron commented Jun 17, 2016

condret commented Jun 21, 2016

ghost commented Jun 22, 2016

deeterius commented Jun 22, 2016

pHr34kY commented Feb 15, 2017

yarwest commented Feb 15, 2017

coquer commented Feb 15, 2017

galenguyer commented Feb 15, 2017

moopie commented Feb 15, 2017

x89 commented Feb 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

morsik commented Feb 15, 2017

IDisposable left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kromit commented Feb 15, 2017 • edited Loading

jonahoffline commented Feb 15, 2017

codingducks commented Feb 15, 2017

StevenGann commented Feb 15, 2017

huysentruitw commented Feb 15, 2017

tekguy commented Feb 15, 2017

shiitake commented Feb 15, 2017

This comment has been minimized.

morsik commented Feb 15, 2017

tekguy commented Feb 15, 2017

MartinJohns commented Jun 15, 2016 •

edited

Loading

crowell commented Jun 15, 2016 •

edited

Loading

morsik commented Jun 16, 2016 •

edited

Loading

qrlpx commented Jun 16, 2016 •

edited

Loading

MrMetric commented Jun 16, 2016 •

edited

Loading

lbialy commented Jun 16, 2016 •

edited

Loading

casper commented Jun 16, 2016 •

edited

Loading

qrlpx commented Jun 17, 2016 •

edited

Loading

kromit commented Feb 15, 2017 •

edited

Loading