Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on implicit copies for event assignment within readonly members #35710

Merged
merged 7 commits into from
Jul 16, 2019
Merged

Warn on implicit copies for event assignment within readonly members #35710

merged 7 commits into from
Jul 16, 2019

Conversation

RikkiGibson
Copy link
Contributor

Resolves #35610

@RikkiGibson RikkiGibson requested a review from a team as a code owner May 14, 2019 23:02
@RikkiGibson RikkiGibson added this to the 16.2.P2 milestone May 14, 2019
jcouv
jcouv approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv self-assigned this May 16, 2019
@RikkiGibson RikkiGibson requested a review from a team May 16, 2019 20:57
@RikkiGibson
Copy link
Contributor Author

Need a second sign off for a small change please @dotnet/roslyn-compiler

@AlekseyTs
Copy link
Contributor

@RikkiGibson It looks like some tests are failing

@AlekseyTs
Copy link
Contributor

Done with review pass (iteration 3)

@RikkiGibson
Copy link
Contributor Author

Oops, changing the whitespace broke the expected diagnostic locations. Will fix.

@jinujoseph jinujoseph modified the milestones: 16.2.P2, 16.2 Jun 9, 2019
@RikkiGibson RikkiGibson modified the milestones: 16.2, 16.3 Jul 11, 2019
@RikkiGibson RikkiGibson requested a review from a team July 12, 2019 18:48
@RikkiGibson
Copy link
Contributor Author

@dotnet/roslyn-compiler Please review this small bug fix.

333fred
333fred approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider testing on a readonly struct as well as individual readonly members. Otherwise, LGTM (commit 6)

@RikkiGibson RikkiGibson merged commit 009a161 into dotnet:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs left review comments

@333fred 333fred 333fred approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
16.3
Development

Successfully merging this pull request may close these issues.

WRN_ImplicitCopyInReadOnlyMember not given for event assignment
5 participants
@RikkiGibson @AlekseyTs @333fred @jcouv @jinujoseph