Corrected misspellings in code comments #3577
Conversation
|
@Pilchie Could you tag some team members for review? |
| @@ -1252,7 +1252,7 @@ internal bool IsRealSigned | |||
| { | |||
| // A module cannot be signed. The native compiler allowed one to create a netmodule with an AssemblyKeyFile | |||
| // or Container attribute (or specify a key via the cmd line). When the module was linked into an assembly, | |||
| // alink would sign the assembly. So rather than give an error we just don't sign when outputting a module. | |||
| // a link would sign the assembly. So rather than give an error we just don't sign when outputting a module. | |||
There was a problem hiding this comment.
Should be 'alink' (the framework tool) I believe.
|
LGTM |
| @@ -323,7 +323,7 @@ private static void MarkReachableFromBranch(ArrayBuilder<BasicBlock> reachableBl | |||
| { | |||
| // if branch is blocked by a finally, then should branch to corresponding | |||
| // BlockedBranchDestination instead. Original label may not be reachable. | |||
| // if there are no blocking finallys, then BlockedBranchDestination returns null | |||
| // if there are no blocking finallies, then BlockedBranchDestination returns null | |||
There was a problem hiding this comment.
Maybe "finally blocks" instead?
|
LGTM |
Corrected misspellings in code comments
|
@VSadov I would like to address review comments, but it looks like you already merged. Can I still add commits to my branch so they get added here? If not, how to proceed? |
|
@jaredpar I'm not sure how to proceed here. Can you help me? |
|
one way to find out :-) |
|
@bkoelman I think the best way is to open a new PR for addressing the feedback. |
|
Thanks for helping out guys. I tried adding more commits to my branch. After that, Github suggested to create a new pull request, because it saw this one was already merged. Awesome! Can someone merge #3729 for me? |
Manual correction of some spelling errors, one by one.
Also changed smart single/double quotes into regular quotes (except in tests that verify for their occurrence).