don't suggest this in a static local function alternative #35825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YairHalberstadt
force-pushed
the
dont-suggest-this-in-static-local-functions-alternative
branch
from
72e712b to
2ea6839
Compare
|
I wouldn't review this until the compiler team has decided on the correct approach in #35822 |
|
@YairHalberstadt Thanks for the heads up -- I'll watch both then. |
|
(still watching the other one) |
|
@YairHalberstadt Since we're going with the other one, OK to close this one? Any other value in this you want to keep? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the alternative option suggested in #35822, shown here for comparison.