Features/nullchecking binding #36095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
reviewed
May 31, 2019
src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
May 31, 2019
src/Compilers/CSharp/Portable/Symbols/Source/SourceDelegateMethodSymbol.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
May 31, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedVariableTests.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
May 31, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedVariableTests.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
May 31, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedVariableTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
May 31, 2019
src/Compilers/CSharp/Portable/Symbols/Source/SourceDelegateMethodSymbol.cs
Show resolved
Hide resolved
RikkiGibson
reviewed
May 31, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedVariableTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
May 31, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedVariableTests.cs
Outdated
Show resolved
Hide resolved
RikkiGibson
reviewed
May 31, 2019
| // delegate void Del(int x!, int y); | ||
| Diagnostic(ErrorCode.ERR_MustNullCheckInImplementation, "int x!").WithArguments("int x!").WithLocation(6, 32)); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Please add a basic "happy" case for a concrete method with a null-checked parameter.
Contributor
Author
There was a problem hiding this comment.
See description. Working cases in next PR?
cston
approved these changes
Jun 3, 2019
RikkiGibson
approved these changes
Jun 3, 2019
333fred
reviewed
Jun 3, 2019
src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Jun 3, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedParameterTests.cs
Show resolved
Hide resolved
RikkiGibson
approved these changes
Jun 3, 2019
Member
RikkiGibson
left a comment
RikkiGibson
left a comment
There was a problem hiding this comment.
Perhaps the parse errors in NullCheckedAutoProperty could be better, but I feel it's low priority at best
added 2 commits
June 4, 2019 09:51
cston
reviewed
Jun 4, 2019
src/Compilers/CSharp/Test/Semantic/Semantics/NullCheckedParameterTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this exclusively covers error cases of extern/interfaces/abstract classes/delegates. Working cases will be covered in the next PR.
Relates to #36024 (test plan for parameter null-checking)