Add a notice to Tools|Options pages where setting may be overridden by .editorconfig #36103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chborl
added
the
PR For Personal Review Only
chborl
changed the title
chborl
added
Area-IDE
and removed
PR For Personal Review Only
sharwell
suggested changes
Jun 5, 2019
| </data> | ||
| <data name="Code_style_header_use_editor_config" xml:space="preserve"> | ||
| <value>The settings configured here only apply to your machine. To configure these settings to travel with your solution, use .editorconfig files.</value> | ||
| <value>Your .editorconfig file might override the local settings configured on this page which only apply to your machine. To configure these settings to travel with your solution use EditorConfig files. More info</value> |
Contributor
There was a problem hiding this comment.
📝 I don't like this text, but it should not block this pull request. Create an issue to review the wording and create a meeting with at least you, me, and Kendra to review it.
src/VisualStudio/CSharp/Impl/Options/Formatting/FormattingOptionPageControl.xaml.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Impl/Options/CodeStyleNoticeTextBlock.xaml.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Impl/Options/Style/NamingPreferences/NamingStyleOptionPageControl.xaml
Outdated
Show resolved
Hide resolved
| <TextBlock Text="{x:Static local:GridOptionPreviewControl.CodeStylePageHeaderLearnMoreText}"/> | ||
| </Hyperlink> | ||
| </TextBlock> | ||
| <options:CodeStyleNoticeTextBlock Grid.Row="0" Margin="5 0 5 0" /> |
Contributor
There was a problem hiding this comment.
📝 Interesting, never though about the commas being optional, but now that I see it, it makes sense because shapes leave out the commas.
sharwell
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19030
Adds text to the following pages:
VB and C# Code Style | General
VB and C# Code Style | Naming
C# Code Style | Formatting | General
C# Code Style | Formatting | Indentation (and New Lines, Spacing, and Wrapping)
