Skip to content

Conversation

@heejaechang
Copy link
Contributor

@heejaechang heejaechang commented Jun 18, 2019

added very basic telemetry to make dashboard to track how often new feature is being used.

see other features dashboard here
block comment - https://devdiv.visualstudio.com/DevDiv/_dashboards/dashboard/2faa643f-88ea-48b3-8e14-d96874ef9662
type import completion - https://devdiv.visualstudio.com/DevDiv/_dashboards/dashboard/73a410a4-f68c-404f-938a-ab5f821532f9

I didn't add undo tracking telemetry for now. it looks like due to the way code is written, I need a bit of refactoring to add that telemetry, so didn't add it for now. but what I added should at least give us some idea how often it is used in the wild.

@heejaechang heejaechang requested a review from a team as a code owner June 18, 2019 01:32
@heejaechang
Copy link
Contributor Author

tagging @chborl

@heejaechang heejaechang requested a review from chborl June 18, 2019 01:34
Copy link
Contributor

@chborl chborl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chborl chborl self-requested a review June 18, 2019 20:32
@heejaechang
Copy link
Contributor Author

tagging @jinujoseph for approval

@jinujoseph jinujoseph added this to the 16.2.P4 milestone Jun 19, 2019
@jinujoseph jinujoseph merged commit 585f711 into dotnet:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants