Change Range precedence to be just below unary #36543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
force-pushed
the
fix-range-precedence
branch
from
ca42b25 to
f9f35d3
Compare
agocke
force-pushed
the
fix-range-precedence
branch
from
f9f35d3 to
d9eacb3
Compare
agocke
changed the title
Member
Author
|
Note: this doesn't implement all the changes from #36514, but it does move the Range precedence, which I think is the most impactful change as it will take working code and make it an error. |
333fred
approved these changes
Jun 21, 2019
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
LGTM, though it looks like there are test issues.
Member
Author
|
Not sure what happened with the test machines -- they all seemed to hang and disconnect at once. Seems OK on retry |
Member
Author
|
@gafter If we think that we'll still move the Range precedence down, I'd still like to take this. I don't think the precedence inversion is particularly worse than what we have now, and I believe all those cases are currently semantic errors, so changing things later won't be very impactful |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34483, #36112