Change dotnet_diagnostic.*.severity settings to match code style #36566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavasani
approved these changes
Jun 19, 2019
sharwell
approved these changes
Jun 19, 2019
jasonmalinowski
force-pushed
the
change-compiler-editorconfig-settings
branch
from
0e40d2c to
b444c1b
Compare
The code style settings we already had in a .editorconfig file supplied a set of terms to set different diagnostic severities. The terms don't match the underlying compiler enum, but we will adopt them for setting compiler diagnostic settings as well to keep the values consistent inside a .editorconfig file. Fixes dotnet#35690
jasonmalinowski
force-pushed
the
change-compiler-editorconfig-settings
branch
from
b444c1b to
44dbfef
Compare
Member
Author
|
This has all the code reviews needed then. @jinujoseph or @jcouv who wants to give M2 signoff? |
tmeschter
added a commit
to tmeschter/roslyn-project-system
that referenced
this pull request
Jun 25, 2019
Updates the terms used to refer to diagnostic severities to bring us in line with the changes made in dotnet/roslyn#36566. "warn" -> "warning" "info" -> "suggestion" "suppress" -> "none"
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Jun 26, 2019
…ed from master to release\dev16.3-preview1 Not sure why the unit test failures were not caught by the merge PR, as these tests are failing consistently in CI for PRs targeting release\dev16.3-preview1
mavasani
added a commit
that referenced
this pull request
Jun 26, 2019
Fix couple of unit tests that started failing after #36566 merged fro…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code style settings we already had in a .editorconfig file supplied a set of terms to set different diagnostic severities. The terms don't match the underlying compiler enum, but we will adopt them for setting compiler diagnostic settings as well to keep the values consistent inside a .editorconfig file.
Fixes #35690