Unwrap nullability-wrapped symbols in object initializer completion #36718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why these are lowercase but makes the tests harder to read.
This slipped through because we didn't have any tests at all for
the case where we are using the type-inferrer to infer the case like:
a = new A { B = { } }
where the inner one doesn't have a new B before it. The scenario wasn't
new but just happened to be the precise case that was broken.
Fixes dotnet#36702
ryzngard
approved these changes
Jun 24, 2019
Member
Author
|
Tagging @jinujoseph for M2 approval. |
CyrusNajmabadi
approved these changes
Jun 25, 2019
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Approve
Submit feedback approving these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slipped through because we didn't have any tests at all for the case where we are using the type-inferrer to infer the case like:
where the inner one doesn't have a
new Bbefore it. The scenario wasn't new but just happened to be the precise case that was broken.Fixes #36702