make sure we only create OB when VS is running in IDE mode. all comma… #36728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
tagging @jinujoseph and @dotnet/roslyn-ide |
jasonmalinowski
approved these changes
Jun 25, 2019
Member
|
@heejaechang We have a disabled integration test around devenv /build; it was disabled due to flakiness. Now that we have the new retry system in place can you try enabling it so we get coverage on this? |
…nd line mode (and all its variations) we don't need to create OB
heejaechang
force-pushed
the
commandLineOB
branch
from
0f2666d to
2e7212a
Compare
Contributor
Author
|
@jinujoseph moved to 16.3 preview 1 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd line mode (and all its variations) we don't need to create OB
fix - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/936590