Update VS editor SDK version #36811
Merged
Update VS editor SDK version #36811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version contains completion expander support
ivanbasov
approved these changes
Jun 27, 2019
Member
Author
|
@vatsalyaagrawal @jinujoseph for approval |
Contributor
|
@genlu has editor side changes merged already ? |
Member
Author
|
Yes. Inserted in 16.3 p1 in this PR This change can also target 16.3 P2, since we can't merge Roslyn expander PR until 16.3 P1 is released. But I figured that we might as well build against the version that we will be shipped with. |
Member
|
Please be aware that this branch is in QB mode on our side now. @genlu |
Member
Author
|
@jinujoseph Do we need to take this to shiproom? As discussed offline, this is an infra change and the only effect would be making our unit tests run against actual shipping editor bits. |
RikkiGibson
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version contains completion expander support.
@ivanbasov @jinujoseph @vatsalyaagrawal